publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
265 stars 284 forks source link

Fixed Geosearch Bar and Removed Duplicate Code #1303

Closed segun-codes closed 1 year ago

segun-codes commented 1 year ago

Fixes #1302 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Screenshot below illustrates the proper functioning of the geosearch bar.

screen-capture-_2_

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

segun-codes commented 1 year ago

Hi @jywarren, this PR is for you to review (and possibly, merge), many thanks!

The task in this PR is consistent with the work distribution @7malikk and I agreed on.

segun-codes commented 1 year ago

Hi @jywarren, reminder kindly review, many thanks!

7malikk commented 1 year ago

Great job @segun-codes

Concerning the extra commits check this comment by @cesswairimu out: https://github.com/publiclab/Leaflet.DistortableImage/pull/1292#pullrequestreview-1215653577 It helped me, cheers!

segun-codes commented 1 year ago

Oh! @7malikk, many thanks for this. I will apply @cesswairimu's idea on subsequent contributions.

segun-codes commented 1 year ago

Looks great, appreciate this fix!

...many thanks!