publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
265 stars 284 forks source link

change `var` to `const/let` in `local.js` #1304

Closed 7malikk closed 1 year ago

7malikk commented 1 year ago

Hi, this is a first-timer-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barriers for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and look through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

- 52 var files = e.dataTransfer.files;
+ 52 const files = e.dataTransfer.files;
- 54  for (var i = 0, f; (f = files[i]); i++) {
+ 54  for (let i = 0, f; (f = files[i]); i++) {
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

7malikk commented 1 year ago

Hello @jywarren, @cesswairimu, @TildaDares Could you check out this fto?

I confirmed that there are no active PRs attached to this, to reduce the risk of conflicts. It is also self-contained. Thank you!

cesswairimu commented 1 year ago

Looks great :tada: thanks @7malikk

7malikk commented 1 year ago

Thank you @cesswairimu!!

jenny-alexander commented 1 year ago

I would like to make this change!

jenny-alexander commented 1 year ago

Hi @7malikk, I created a PR. Please review when you are able.