publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
265 stars 284 forks source link

Change Keyword `let` to `const` in `src/edit/DistortableImage.Edit.js` #1309

Closed segun-codes closed 1 year ago

segun-codes commented 1 year ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barriers for new contributors. This issue is for you πŸ’

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

πŸ’‘ Learn how to claim πŸ™‹

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

- 350 let opacity;
- 355 opacity = this._transparent ? this.options.opacity : 1;
+ 355 const opacity = this._transparent ? this.options.opacity : 1; 
- 365 let outline;
- 370 outline = this._outlined ? this.options.outline : 'none';
+ 370 const outline = this._outlined ? this.options.outline : 'none';
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

πŸ€”β“ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

segun-codes commented 1 year ago

Hi @cesswairimu, @TildaDares, would you like to have this issue designated as first-timer-only? I think that any variable currently and effectively used as "const" should be declared as such until there's such a need to revert to "let", perhaps due to code extension in the future.

Many thanks!

AtulyaJaiswal commented 1 year ago

Hi, @segun-codes , can I work on this if someone else is not working on this?

segun-codes commented 1 year ago

Hi, @segun-codes , can I work on this if someone else is not working on this?

@TildaDares, can @AtulyaJaiswal go ahead?

TildaDares commented 1 year ago

Hi @segun-codes, of course.

segun-codes commented 1 year ago

Hi, @segun-codes , can I work on this if someone else is not working on this?

So there you go @AtulyaJaiswal.... and thanks @TildaDares.

AtulyaJaiswal commented 1 year ago

Thank you, @segun-codes @TildaDares

AtulyaJaiswal commented 1 year ago

I have generated a PR. Please review it.

segun-codes commented 1 year ago

I have generated a PR. Please review it.

Great progress there! Okay, so next step is to follow advice offered by @cesswairimu on your PR.

vanshdeepsingh-coder commented 1 year ago

Hi, If anyone is not working on this i'd like to give it a try

TildaDares commented 1 year ago

Completed in #1318