Closed owaisali8 closed 1 year ago
Thanks for opening this pull request! Dangerbot
will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000
(for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅
Please review, @cesswairimu
@owaisali8 this looks great, thanks! just a small feedback - I think using const
would be more appropriate than let
in this scenario since we never change those values after we set them
Done @sashadev-sky.
Please review, @cesswairimu @sashadev-sky
looks good! would you mind merging the latest changes from main
before I approve? Let me know if you have any questions
Latest changes from main
has been merged
Merging now, thanks all 🎉🎉🎉 Nice to see you around @sashadev-sky 😊
Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://mapknitter.org in the next few days. Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!
Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌
Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉
Read about how to help support another newcomer here, or find other ways to offer mutual support here.
Thank you everyone for guiding me on how to contribute.
Change Keyword var to let in src/util/ImageUtil.js
Fixes #1307
grunt test
Thanks!