Functionality to Detect JSON in Shareable URL

segun-codes commented 1 year ago

Fixes #1330

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

[X] PR is descriptively titled 📑 and links the original issue above 🔗
[x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
[X] code is in uniquely-named feature branch and has no merge conflicts 📁
[ ] screenshots/GIFs are attached 📎 in case of UI updates
[ ] @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

segun-codes commented 1 year ago

Hi @jywarren, kindly review the JSON detector for merging, many thanks!

segun-codes commented 1 year ago

Looks great. Can you rebase this so it includes only one commit? In the future it'll help to work from a local branch other than main.

Great job!

Yeah, I actually rebased but for some reasons, it apparently did not work out. I will take a second look now. Many thanks!

jywarren commented 1 year ago

Got it. Moving to #1331!

publiclab / Leaflet.DistortableImage