Closed sudeep162002 closed 1 year ago
Thanks for opening this pull request! Dangerbot
will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000
(for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅
Hello @sudeep162002 Great job 🎉
Kindly add the number to the corresponding issue you solved to help the maintainers. Thank you!
I'm sure it'll get reviewed soon @cesswairimu @TildaDares
Hi @7malikk, feel feee to approve if you think everything looks good. You can either @cesswairimu or me to get it merged.
Thank you both!
Hi @7malikk, feel feee to approve if you think everything looks good. You can either @cesswairimu or me to get it merged.
Thank you both!
Alright, @TildaDares Thank you!
@TildaDares, @cesswairimu I believe this is ready for a merge, thank you!
Great job @sudeep162002 🎉
@sudeep162002, great effort so far. One little change, please place the second code snippet in line 337 instead (and not 339). Issue #1332 is now updated to reflect this change, sorry for the mix-up.
@sudeep162002, great effort so far. One little change, please place the second code snippet in line 337 instead (and not 339). Issue #1332 is now updated to reflect this change, sorry for the mix-up.
Thank you for catching that @segun-codes, must've been an oversight on my part.
changed the pr according to updated issue please review.
Hello @sudeep162002 Great job 🎉
Kindly add the number to the corresponding issue you solved to help the maintainers. Thank you!
I'm sure it'll get reviewed soon @cesswairimu @TildaDares
@sudeep162002, please, fix @7malikk's suggestion above (i.e., replace 0000 in Fixes #0000 (<=== Add issue number here) with the issue number of the issue this PR is related to).
done .
@7malikk, things look all set here, over back to you.
Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://mapknitter.org in the next few days. Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!
Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌
Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉
Read about how to help support another newcomer here, or find other ways to offer mutual support here.
Fixes #1332
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!