Closed 7malikk closed 1 year ago
@jywarren All done here, thanks!
@jywarren I believe this is ready
It's so strange... I don't actually see the change in https://github.com/publiclab/Leaflet.DistortableImage/pull/1354/files, but, in this screenshot, it shows that it's already been fixed??
Ah, i see - @7malikk did you commit to the main branch separately?
If so, it's OK in this one situation because it's a fix but I'd like to coordinate all commits together and do them through PRs. Maybe somehow you accidentally pushed to PublicLab's main branch?
In any case, it looks like we are OK now, I can merge this to include your final tweaks... but yeah, I think maybe somehow you were unintentionally pushing to PublicLab's main branch?
Oh maybe I did, unintentionally. But that's so weird
Hmm, what I'll do is put some more branch protection on so you can't do it unintentionally. No worries!
Alright, thanks @jywarren
Fixes #1352 Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
UI Changes