publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
265 stars 284 forks source link

fixed downloadJSON error #1354

Closed 7malikk closed 1 year ago

7malikk commented 1 year ago

Fixes #1352 Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

UI Changes

downloadJSON-three

7malikk commented 1 year ago

@jywarren All done here, thanks!

7malikk commented 1 year ago

@jywarren I believe this is ready

jywarren commented 1 year ago

It's so strange... I don't actually see the change in https://github.com/publiclab/Leaflet.DistortableImage/pull/1354/files, but, in this screenshot, it shows that it's already been fixed??

image

Ah, i see - @7malikk did you commit to the main branch separately?

https://github.com/publiclab/Leaflet.DistortableImage/commit/d4c5d123fac4039570726296a3407dffeb7af44c

If so, it's OK in this one situation because it's a fix but I'd like to coordinate all commits together and do them through PRs. Maybe somehow you accidentally pushed to PublicLab's main branch?

jywarren commented 1 year ago

In any case, it looks like we are OK now, I can merge this to include your final tweaks... but yeah, I think maybe somehow you were unintentionally pushing to PublicLab's main branch?

7malikk commented 1 year ago

Oh maybe I did, unintentionally. But that's so weird

jywarren commented 1 year ago

Hmm, what I'll do is put some more branch protection on so you can't do it unintentionally. No worries!

7malikk commented 1 year ago

Alright, thanks @jywarren