save map dropdown

[7malikk]

• [x] PR is descriptively titled 📑 and links the original issue above 🔗
• [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
• [x] code is in a uniquely-named feature branch and has no merge conflicts 📁
• [x] screenshots/GIFs are attached 📎 in case of UI updates
• [x] @mention the original creator of the issue in a comment below for help or for a review

UI Changes

[7malikk]

@jywarren here's the dropdown button for the saveMaps

[7malikk]

Hello @jywarren This is coming out quite nicely, here's a GIF:

I'm moving to the aspect where the user clicks on recover to load the saved map I stored each SavedMap's index as a dataset in the recover button, I intend to use this to filter out the particular map to load.

I may need to extract the function to accomplish this

What are your thoughts?

[jywarren]

Wow it looks great!! Which function are you referring to? Sorry, I don't quite follow.

On Fri, Feb 17, 2023, 12:28 PM Malik @.***> wrote:

Hello @jywarren https://github.com/jywarren This is coming out quite nicely, here's a GIF: [image: saveMapModal] https://user-images.githubusercontent.com/75104021/219722382-7924e9be-5504-43d8-a78a-8c369c272592.gif

I'm moving to the aspect where the user clicks on recover to load the saved map I stored each SavedMap's index as a dataset in the recover button, I intend to use this to filter out the particular map to load.

I may need to extract the function to accomplish this

What are your thoughts?

— Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/pull/1357#issuecomment-1434983932, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J3WDL7YDTTDGTPZZM3WX6YLTANCNFSM6AAAAAAU5C3VHA . You are receiving this because you were mentioned.Message ID: @.***>

[7malikk]

Wow it looks great!! Which function are you referring to? Sorry, I don't quite follow.

I was referring to the reconstructMapFromJson here on line 260.

I was thinking I'd need to extract just a piece of it, but for reusability I could refactor it, to accept an Objectas a source to reconstruct the map.

[jywarren]

Ah I see. Yes I think making it a more general purpose function that accepts an object makes sense!

[7malikk]

Hello @jywarren Here's the final look of the modal:

What do you think?

[jywarren]

It looks great! Is this ready for review and merge then? Thanks!

On Mon, Feb 20, 2023, 5:31 AM Malik @.***> wrote:

Hello @jywarren https://github.com/jywarren Here's the final look of the modal:

[image: recoverMap] https://user-images.githubusercontent.com/75104021/220080558-4d30a65f-8ecd-4d5c-854d-06c3959c985b.gif

What do you think?

— Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/pull/1357#issuecomment-1436713126, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JZRMAAWGNJSM2ZSJJDWYNBYLANCNFSM6AAAAAAU5C3VHA . You are receiving this because you were mentioned.Message ID: @.***>

[7malikk]

@jywarren Yes it is ready for review and merge, Thank you!

[7malikk]

@jywarren I've removed all logs

[jywarren]

Great job!!