publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
273 stars 285 forks source link

Map Reconstruction Support for JSON Files from Legacy Mapknitter #1358

Closed segun-codes closed 1 year ago

segun-codes commented 1 year ago

Fixes #1350

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Hi @jywarren, having spent some time unsuccessfully trying to get programmatic download URL for the JSON files for legacy Mapknitter from wayback machine, I decided to implement the DnD aspect first before returning to the said URL-based map reconstruction shortly. Here, the DnD aspect is ready for your review. Your thoughts?

Illustration 1: ceres-2 Illustration-1(ceres-2)

Illustration 2: 01-test--2 Illustration-2(01-test--2-warpables)

Illustration 2.1: Illustration 2 above updated into this after some more seconds Illustration-2 1(01-test--2-warpables)

Illustration 3: --10 Illustration-3(--10-warpables)

Illustration 4: -emf Illustration-4(-emf-warpables)

Illustration 5: I tried out the URL from error messages returned to browser and got this Illustration 5 (ErrorChecked)

jywarren commented 1 year ago

Ah sorry, DnD = drag n drop, sorry now I feel silly! πŸ˜‚

segun-codes commented 1 year ago

This is looking good -- I didn't get what DnD meant but you mean like downloaded and dragged onto the page, instead of directly from the URL, right? That's OK!

Yes.

segun-codes commented 1 year ago

Code is now updated, you may want to take a second look. Thanks!

jywarren commented 1 year ago

Noting for future readers, we're doing a follow-up for correct corner order in https://github.com/publiclab/Leaflet.DistortableImage/pull/1359