publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
265 stars 284 forks source link

compartmentalize archive demo savedMaps into separate module #1360

Closed 7malikk closed 1 year ago

7malikk commented 1 year ago

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

7malikk commented 1 year ago

Hello @jywarren I moved the savedMaps modal to another file but for some reason, the build is canceled

jywarren commented 1 year ago

Hmm, weird. I'll try re-running.

7malikk commented 1 year ago

Hmm, weird. I'll try re-running.

Alright

jywarren commented 1 year ago

Aha - they're trying to tell us that Ubuntu 18 won't be supported much longer:

This is a scheduled Ubuntu-18.04 brownout. The Ubuntu-18.04 environment is deprecated and will be removed on April 1st, 2023. For more details, see https://github.com/actions/runner-images/issues/6002
[build: .github#L1](https://github.com/publiclab/Leaflet.DistortableImage/pull/1360/files#annotation_9069805981)
The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see https://github.com/actions/virtual-environments/issues/6002

we should use ubuntu-latest

jywarren commented 1 year ago

I changed it here!

https://github.com/7malikk/Leaflet.DistortableImage/blob/70f70d0b62fecab4cbbdd154bf40a7c562249ef4/.github/workflows/build.yml#L5

7malikk commented 1 year ago

Oh, alright Great! Thanks

jywarren commented 1 year ago

Great! Is it ready to merge? Let me know, great job!

7malikk commented 1 year ago

It looks like there was a formatter run; this is OK but if possible can you run that in a separate PR in the future so that it's easier to review just the contents and goals of this PR? Thank you! This looks good and if you've tested it out, we can merge once it passes!

Ohh, okay will do

7malikk commented 1 year ago

@jywarren Yea it is merge ready

jywarren commented 1 year ago

Excellent!!