fix in saveMaps & reconstructMapFromJson

publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images

https://publiclab.github.io/Leaflet.DistortableImage/examples/

BSD 2-Clause "Simplified" License

265 stars 284 forks source link

fix in saveMaps & reconstructMapFromJson #1370

Closed 7malikk closed 1 year ago

7malikk commented 1 year ago

While going through the latest code, I noticed some minor bugs in saveMaps.js and reconstructMapFromJson(), nothing major

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

[x] PR is descriptively titled 📑 and links the original issue above 🔗
[ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
[x] code is in a uniquely-named feature branch and has no merge conflicts 📁
[ ] screenshots/GIFs are attached 📎 in case of UI updates
[x] @mention the original creator of the issue in a comment below for help or for a review

7malikk commented 1 year ago

@jywarren Could you review this?

jywarren commented 1 year ago

I'll try later today, can you describe the fix for me so I know what to look for? Thanks!

On Mon, Feb 27, 2023, 9:15 AM Malik @.***> wrote:

@jywarren https://github.com/jywarren Could you review this?

— Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/pull/1370#issuecomment-1446397710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JZUTTYOK7Q6BTH63ULWZSZH5ANCNFSM6AAAAAAVJOTZBY . You are receiving this because you were mentioned.Message ID: @.***>

jywarren commented 1 year ago

Hi Malik, so is this ready to merge or are there still sections you're unsure of? It's ok to leave the formatting this time!

7malikk commented 1 year ago

Oh, if we're leaving the formatting, then I believe everything is fine Thanks @jywarren