publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
273 stars 285 forks source link

Shorter URL Support for Legacy JSON Files #1371

Closed segun-codes closed 1 year ago

segun-codes commented 1 year ago

Fixes #1367

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

The PR supports reconstruction of map using shorten URL for json files from legacy mapknitter.org, see Illustration 1 for more details. Here's a sample of such URL:

http://localhost:8081/examples/archive.html?kl=041114flcwetlandsjv

Note:

  1. Query parameter key must be: "kl" (recall, we used ordinary "k" for mk-lite generated json files).
  2. The value (i.e., "041114flcwetlandsjv") to the query parameter key must be: name of the json file (without file extension).
  3. As per step 1 above, I figure it's a simple approach. The alternative of using ordinary "k" seems unnecessarily slightly complex and amounts to a waste of resources. Using documentation, I think users can apply step 1 above with ease.

Illustration 1: lllustration-1

segun-codes commented 1 year ago

Hi @jywarren, this PR is now ready for your review and consideration for merging.

jywarren commented 1 year ago

This looks great!!! Could you resolve conflicts and then we can merge?

segun-codes commented 1 year ago

Interesting!!! I didn't get any alert to resolve conflict as there was none, all tests passed as at the last time I checked. Well, conflict is now resolved and ready for your attention. Many thanks!

jywarren commented 1 year ago

Ah it's because I just merged Malik's pr! Sorry!

On Tue, Feb 28, 2023, 8:18 AM Segun @.***> wrote:

Interesting!!! I didn't get any alert to resolve conflict as there was none, all tests passed as at the last time I checked. Well, conflict is now resolved and ready for your attention. Many thanks!

β€” Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/pull/1371#issuecomment-1448166467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JYGP5CFZACJD2KRUMDWZX3JLANCNFSM6AAAAAAVKUOBDY . You are receiving this because you were mentioned.Message ID: @.***>

jywarren commented 1 year ago

Great work!!!