Closed segun-codes closed 1 year ago
Hi @jywarren, this PR is now ready for your review and consideration for merging.
This looks great!!! Could you resolve conflicts and then we can merge?
Interesting!!! I didn't get any alert to resolve conflict as there was none, all tests passed as at the last time I checked. Well, conflict is now resolved and ready for your attention. Many thanks!
Ah it's because I just merged Malik's pr! Sorry!
On Tue, Feb 28, 2023, 8:18 AM Segun @.***> wrote:
Interesting!!! I didn't get any alert to resolve conflict as there was none, all tests passed as at the last time I checked. Well, conflict is now resolved and ready for your attention. Many thanks!
β Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/pull/1371#issuecomment-1448166467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JYGP5CFZACJD2KRUMDWZX3JLANCNFSM6AAAAAAVKUOBDY . You are receiving this because you were mentioned.Message ID: @.***>
Great work!!!
Fixes #1367
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
The PR supports reconstruction of map using shorten URL for json files from legacy mapknitter.org, see Illustration 1 for more details. Here's a sample of such URL:
http://localhost:8081/examples/archive.html?kl=041114flcwetlandsjv
Note:
Illustration 1: