publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
265 stars 284 forks source link

Little documentation #1374

Closed segun-codes closed 1 year ago

segun-codes commented 1 year ago

Fixes #1356

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

segun-codes commented 1 year ago

Hi @jywarren, @7malikk, here's the documentation. you may kindly review.

  1. https://github.com/segun-codes/Leaflet.DistortableImage-arc/blob/prelim-documentation/examples/README.md
  2. https://github.com/segun-codes/Leaflet.DistortableImage-arc/blob/prelim-documentation/README.md (then search for recreateImagesFromJsonUrl)
  3. You will find this in the "Files Changed" tab.
segun-codes commented 1 year ago

@jywarren @7malikk, your reviews are still being awaited. Many thanks!

segun-codes commented 1 year ago

This is really nice documentation! I'd like to make some text tweaks to it and add a commit here, but great job in documenting the various main features.

Yes, please. You can go ahead...

jywarren commented 1 year ago

OK, sorry that took me a while! I also better understand the question about pointing at github pages vs. the local copy. I opted for GH Pages, so that it's more immediately usable!

jywarren commented 1 year ago

OK, I think we can merge now! Thank you!!! Next up... blog post when i get a chance!!

segun-codes commented 1 year ago

OK, I think we can merge now! Thank you!!! Next up... blog post when i get a chance!!

Oh! okay.. many thanks!

segun-codes commented 1 year ago

OK, sorry that took me a while! I also better understand the question about pointing at github pages vs. the local copy. I opted for GH Pages, so that it's more immediately usable!

Okay.