publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
265 stars 284 forks source link

changing from getElementById to a querySelector Updated pixelorigin.js #1376

Open hound77 opened 1 year ago

hound77 commented 1 year ago

Fixes #1174 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

welcome[bot] commented 1 year ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

hound77 commented 1 year ago

@TildaDares please review the pr

cesswairimu commented 1 year ago

Hi @hound77, it seems there was another PR solving this https://github.com/publiclab/Leaflet.DistortableImage/pull/1338 which just closed the issue.

cesswairimu commented 1 year ago

Feel free to browse other issues and check if there is a PR for it before you proceed. You can find the PR links on the right-side panel of the issue. Thanks