search

publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
272 stars 285 forks source link

Toolbar disappears when clicking on rotate icon, then on image (in simple demo) #221

Closed flopail closed 5 years ago

flopail commented 5 years ago

... and no way to increase/reduce proportionally image size. Does something change recently in simple demo (below) ? https://publiclab.github.io/Leaflet.DistortableImage/examples/

Thanks, :)

welcome[bot] commented 5 years ago

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄 If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

rexagod commented 5 years ago

@flopail This has been fixed in #201. As for the proportional resize, we have a "scale" function for the same, and we are working on including it in the toolbar. Thanks!

sashadev-sky commented 5 years ago

@flopail ^ to add on I think you can access it now with the hotkey s but in the PR referenced above we are also fixing a bug where hitting s again won't toggle you out of scale mode so you'll have to hit a hotkey for another handle if you want to get out of it .. until we merge mentioned PR

flopail commented 5 years ago

Thank you @rexagod and @sashadev-sky !

sashadev-sky commented 5 years ago

ok this is fixed now via #201 ... @jywarren do we need to do anything else to make sure the demo itself is updated?

jywarren commented 5 years ago

I can update the demo now! I merge to gh-pages with a merge commit and install any necessary new npm packages, then push.

On Fri, Apr 19, 2019, 10:01 PM Sasha Boginsky notifications@github.com wrote:

ok this is fixed now via #201 https://github.com/publiclab/Leaflet.DistortableImage/pull/201 ... @jywarren https://github.com/jywarren do we need to do anything else to make sure the demo itself is updated?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/issues/221#issuecomment-485050054, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J5E53PDAU3ZZ7P55C3PRJ2NZANCNFSM4HGJKRQA .

sashadev-sky commented 5 years ago

@jywarren awesome! Updates are live there.

@flopail please revisit demo now and your issue should be resolved!

Thank you, closing via #201