Fix "Editor controls overlay #228"

rexagod commented 5 years ago

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update: This will resolve #228. All that needs to be done is remove the following line, https://github.com/publiclab/PublicLab.Editor/blob/ffcb496c6be2abf813c7e38f8ef3d72a8426251d/src/modules/PublicLab.RichTextModule.js#L251
[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

LCBradley3k commented 5 years ago

I'll give it a shot.

grvsachdeva commented 5 years ago

Great @LCBradley3k! Thanks!

LCBradley3k commented 5 years ago

@gauravano Can I have the change on the master branch of my fork, or do you want it on a separate feature branch?

I ask because - "code is in uniquely-named feature branch and has no merge conflicts"

grvsachdeva commented 5 years ago

I would suggest a separate feature branch too, because it's good to keep your master branch clean. Thanks!

LCBradley3k commented 5 years ago

Thanks @gauravano, made a pull request!

publiclab / PublicLab.Editor