GSoC / Outreachy Editor Project Planning Issues and General Disscussion

[keshav234156]

In this issue, we can discuss about weekly goals and the issue we are going to work during the whole project. I have also made the Summer of Code 2020 project https://github.com/publiclab/PublicLab.Editor/projects/1 to keep the track of Issues To Do, In Progress, Done.

Editor Project Collaboration plan : https://docs.google.com/document/d/1LX1VEi_TEplnduXETqwr8mPPt-hshlg03dLeaa74hMI/edit

UI Improvements

• [x] Make history icons consistent #572
• [x] Main image box #564
• [x] Toolbar Stickness #522
• [x] Choose File Button UI #462
• [x] Image Popup #437
• [x] Popup Disappearing in Editor https://github.com/jywarren/woofmark/pull/3
• [x] Compact Design for main Image Module #594

Bugs

• [x] Made history icons consistent in demo editor fixes #571
• [x] Filename Error #462
• [x] Add support for class attribute in links #547
• [x] Refine drag and drop events https://github.com/jywarren/woofmark/pull/2
• [x] Change heading back into plain text https://github.com/jywarren/woofmark/pull/5
• [x] Replacing uglify-js with Terserhttps://github.com/jywarren/woofmark/pull/29
• [x] fix bold texts loosing formatting https://github.com/jywarren/woofmark/pull/15
• [x] Feature to decenter text in wysiwyg and markdown mode #521
• [x] Fixes Disabling of Markdown buttton on using shortcut keys #465

Features

• [x] Added Custom Insert Module #568
• [x] Adds puppeteer as a dev dependency #565
• [x] Add user workflow for documenting bugs #530
• [x] Added eslint,lint-staged and Husky #519
• [x] Remove file button added #472
• [x] Created issue template chooser #474

Pending bugs and features PR

• [ ] Add "Related work" section to Title module #534
• [ ] Custom insert map #546 (WIP)
• [ ] upgrade Bootstrap to 4 #566 (WIP )
• [ ] Hide publish bar when typing on mobile devices #583

Tests

• [x] Remove file test #574
• [x] Jest test for bold and italic command #543
• [x] Choose file updated test #542

• [x] Heading test https://github.com/jywarren/woofmark/pull/34

  Left undone

• [ ] Proper documentation with each module. #501
• [ ] Making toolbar Responsive #496
• [ ] Implementing the feature of darkening of all the icons #494
• [ ] Adding functionalities to Extras tab. #500
• [ ] Embedding audio, video and calendar #499

Whenever working on any Issue please leave a comment on the issue or Assign the issue to yourself.

Thanks !!!

[keshav234156]

Hi @shreyaa-s @NitinBhasneria @Shulammite-Aso , For this week let us focus on the opening issue from the proposal that we all made. You all can then add the links above in the task list.

[Shulammite-Aso]

Most of the issues are the same in our proposals. I think splitting up the project so that each one of us will have specific areas to focus on, will be a fine thing.

https://github.com/publiclab/plots2/issues/7873 had mentioned the same thing.

What do you think?

[keshav234156]

Yes, I saw all the proposals. Roughly around 75% of the proposal is the same. We can open all the remaining issues that are different and not present in other's proposal

I don't think giving a complete specific area to each one of us would be useful. Let's first open up the completely small independent issue and then we can start by claiming that independent issues.

Thanks!!

[shreyaa-s-zz]

I agree with @Shulammite-Aso . My proposal also focuses on some issues related to the work you've mentioned. This would mean a greater chance of the code breaking or having discrepancies if we were to work separately. A big team on Editor would yield the desired results only if we were to work as a team. Let's have a meeting where we could discuss our ideas, plan the next week, divide the work and establish a workflow. What say @keshav234156 @Shulammite-Aso @NitinBhasneria ?

[keshav234156]

@shreyaa-s We can use this thread to discuss our ideas, plan the next week, divide the work and establish a workflow

[shreyaa-s-zz]

@keshav234156 that's fine by me.

[NitinBhasneria]

I agree with dividing and working seperately. But we all should know what each others are doing. @keshav234156 I agree with you.

[NitinBhasneria]

Yes, I saw all the proposals. Roughly around 75% of the proposal is the same. We can open all the remaining issues that are different and not present in other's proposal

I don't think giving a complete specific area to each one of us would be useful. Let's first open up the completely small independent issue and then we can start by claiming that independent issues.

Thanks!!

Here, I think that deciding the workflow and then divide the work will be a better option. simply claiming the issues won't help much. So, first of all we should decide what will be the best workflow as a team. Let's pin @jywarren @cesswairimu @emilyashley for there views. Thanks.

[Shulammite-Aso]

Here, I think that deciding the workflow and then divide the work will be a better option.

Let's pin @jywarren @cesswairimu @emilyashley for there views. Thanks.

I think this is cool!
We're either going to be dividing the work up and deciding how best to work on them by ourselves, or the mentors already have plans coming in place. I think we have to hear from them first either ways.

Thank you.

[keshav234156]

ok, Let's start by making a list of different sub-project projects possible

1. Potential Bugs
2. Mobile view optimization
3. Adding a new module for Customizing maps on PublicLab.org #419
4. Adding test suite
5. Adding a linting tool
6. Develop a workflow for documenting hard-to-reproduce bugs, so that users can report and document them (with screenshots, GIFs, screen recordings, js console captures?)

[keshav234156]

@NitinBhasneria @Shulammite-Aso @shreyaa-s Please list other sub-project possible other than this ?

[cesswairimu]

Hey all, congrats everyone once more and I love the discussions already going on here :tada: :tada: ... I think with all of you working on one project, the subprojects are bond to inter twin at any moment .. working collaboratively is more of the approach we should be going for...of course at a given time everyone will be working on separate issues but you might find one issue is dependent on or complete something, someone else is working on... makes sense?

We normally let the interns decide on how to divide the issues among themselves but we also encourage reviewing each other pull requests, interacting on discussions on each others work, picking up approaches and mockups from each others proposals to come up with a better implementation on the parts you are working on e.t.c

[Shulammite-Aso]

Thank you @cesswairimu Noted!! 🎉

[shreyaa-s-zz]

Hey @cesswairimu Thanks for the input!

@keshav234156 if we're making a list of sub projects that we can cover/discuss, here's my input:

• [ ] 1. Adding functionalities to Extras tab. #500 (this is a major project)

• [ ] 2. Issues and UI for Add location #497

• [ ] 3. Embedding audio, video and calendar #499

[Shulammite-Aso]

@NitinBhasneria @Shulammite-Aso @shreyaa-s Please list other sub-project possible other than this ?

There is also; User testing, using lookback.io perhaps?

Also the new module will be for adding custom contents like maps and a grid of other contents in publiclab.org. I think I would like to work on this part if we don't mind?? Only I'm not sure yet if there should be a different module for adding maps and another for adding grid contents, or if they should both be using the same module? I'm yet to figure that out.

[keshav234156]

Can we all choose some other channel to disscuss.I think it's very difficult to chat here on github. We can create a room on riot or any other similar software. what are your thoughts on this??

[Shulammite-Aso]

I have a UI sketch of the new custom inserts on my proposal. And I'm thinking the UI could be handled differently from the actual module extension. But I can't tell how intertwined the two will be yet to decide if different persons can handle each.

[Shulammite-Aso]

Can we all choose some other channel to disscuss.I think it's very difficult to chat here on github. We can create a room on riot or any other similar software. what are your thoughts on this??

Oh! I think our mentors should be able to come back and follow up on our chats. That may be difficult if we create a different group??

[Shulammite-Aso]

Unless it will be cool to have them their too.

[NitinBhasneria]

Can we all choose some other channel to disscuss.I think it's very difficult to chat here on github. We can create a room on riot or any other similar software. what are your thoughts on this??

@keshav234156 I agree with you but as @Shulammite-Aso said it would be difficult to follow up our chats. Also, I do think we four of us can have a different suitable platform for discussing the workflow and then we can tell the workflow to the mentors after deciding.

[keshav234156]

https://riot.im/app/#/room/!hFdwKeIWxjjMOPWhpb:matrix.org just made a room. @Shulammite-Aso yes, Mentors can also be added in this room. Please send a "Hi" message so that I can know that you have been added and it works properly

[keshav234156]

@NitinBhasneria ok then we can discuss it here

[keshav234156]

@keshav234156 if we're making a list of sub projects that we can cover/discuss, here's my input:

7. Adding functionalities to Extras tab. #402 (this is a major project)
8. Adding tools for shortcode syntax.

For Adding functionalities to Extras tab we need to first discuss with @jywarren . This issue was opened up by a contributor and it hasn't be approved by Jeff yet. I beleive Adding tools for shortcode syntax and Custom Insert are similar?

[NitinBhasneria]

ok, Let's start by making a list of different sub-project projects possible

1. Potential Bugs
2. Mobile view optimization
3. Adding a new module for Customizing maps on PublicLab.org #419
4. Adding test suite
5. Adding a linting tool
6. Develop a workflow for documenting hard-to-reproduce bugs, so that users can report and document them (with screenshots, GIFs, screen recordings, js console captures?)

I think the first one "Potential Bugs" should be elaborated more @keshav234156 In other words there are many issues in this potential bugs which should be divided according to the modules

[keshav234156]

@shreyaa-s sorry, I misunderstood, saw your proposal and it mentions Adding functionalities to the 'Extras' tab. I think you wanted this to be a sub-project. So can you please open up issues for different modules as mentioned in your proposal

[NitinBhasneria]

@shreyaa-s sorry, I misunderstood, saw your proposal and it mentions Adding functionalities to the 'Extras' tab. I think you wanted this to be a sub-project. So can you please open up issues for different modules as mentioned in your proposal

Ahh, @keshav234156 I think we should first list out the things we need to work and then divide them according to the interest then we can individually open the issues. What do you think?

[shreyaa-s-zz]

https://riot.im/app/#/room/!hFdwKeIWxjjMOPWhpb:matrix.org just made a room. @Shulammite-Aso yes, Mentors can also be added in this room. Please send a "Hi" message so that I can know that you have been added and it works properly

It says failed to join room. You've not been invited to this room.

[shreyaa-s-zz]

@keshav234156 if we're making a list of sub projects that we can cover/discuss, here's my input:

7. Adding functionalities to Extras tab. #402 (this is a major project)
8. Adding tools for shortcode syntax.

For Adding functionalities to Extras tab we need to first discuss with @jywarren . This issue was opened up by a contributor and it hasn't be approved by Jeff yet. I beleive Adding tools for shortcode syntax and Custom Insert are similar?

I believe so, yes. Also I think we need to take @jywarren 's approval and input on the same. It will be easier to prioritize and work on the features accordingly.

[keshav234156]

I think the first one "Potential Bugs" should be elaborated more @keshav234156 In other words there are many issues in this potential bugs which should be divided according to > modules @NitinBhasneria all the potential bugs don't belong to any particular module These changes are to bemade in woofmark

[NitinBhasneria]

I think the first one "Potential Bugs" should be elaborated more @keshav234156 In other words there are many issues in this potential bugs which should be divided according to > modules @NitinBhasneria all the potential bugs don't belong to any particular module These changes are to bemade in woofmark

Its ok then.

[keshav234156]

https://riot.im/app/#/room/!hFdwKeIWxjjMOPWhpb:matrix.org just made a room. @Shulammite-Aso yes, Mentors can also be added in this room. Please send a "Hi" message so that I can know that you have been added and it works properly

It says failed to join room. You've not been invited to this room.

Can you please check it now. I have changed room setting

[keshav234156]

@shreyaa-s i think you can only join by invite

[NitinBhasneria]

@keshav234156 Can't join....

[shreyaa-s-zz]

@shreyaa-s i think you can only join by invite

I've joined.

[NitinBhasneria]

Yea I have too now.

[keshav234156]

Shulammite-Aso you can also join

[NitinBhasneria]

From my side I would like to add:

1. Title bar tag integration improvement: Addition, deletion of the tags. #470
2. CSS or UI improvement. #495
3. Drag and Drop file improvements. #504
4. The user interfaces to attach files or image improvement.
5. Table inserting format. So that we can give format to the tables. #506
6. Proper documentation with each module. #501
7. Data Embedding. When copied from other sources to the editor. #505

I will add some more with time. Thank you

[keshav234156]

@NitinBhasneria Looks a good list.Can you please open a detail issues for each of the following .Just copy - pasting from proposal that you have made for above tasks

[shreyaa-s-zz]

@NitinBhasneria Looks a good list.Can you please open a detail issues for each of the following .Just copy - pasting from proposal that you have made for above tasks

I'll go ahead and do the same.

[keshav234156]

I am really sorry. That occurs because of end-to-end encryptions and it can't be disabled now .So just created a new room https://riot.im/app/#/room/!ZuaTBWNFvZoftPwQmG:matrix.org .Hope this will able to handle all the mess

[NitinBhasneria]

Well, its ok.

[keshav234156]

@NitinBhasneria @shreyaa-s Please update this list as well to keep things at one place https://github.com/publiclab/PublicLab.Editor/issues/490#issue-613024913

[shreyaa-s-zz]

Update the list, how?

@NitinBhasneria @shreyaa-s Please update this list as well to keep things at one place #490 (comment)

[NitinBhasneria]

He just means to just update your comment (list of issues).

[shreyaa-s-zz]

He just means to just update your comment (list of issues).

Done!

[keshav234156]

No, I meant updating above list. I think that also comes with reviewer right

[shreyaa-s-zz]

No, I meant updating above list. I think that also comes with reviewer right

There's no such option to edit your comment.

[shreyaa-s-zz]

Are you talking about issue list?

No, the initial comment of this discussion.

[NitinBhasneria]

No, I meant updating above list. I think that also comes with reviewer right

There's no such option to edit your comment.

Yea, not enough rights.

[keshav234156]

done!! Looks almost a complete list now!!