search

publiclab / blurred-location

A JavaScript library to help manage variable location privacy through a "blurred location" model
GNU General Public License v3.0
4 stars 1 forks source link

Precision helper functions created . #6

Closed sagarpreet-chadha closed 5 years ago

sagarpreet-chadha commented 5 years ago

Fixes #4 !

sagarpreet-chadha commented 5 years ago

Hey @jywarren 😄 ! This new function getGridSizeFromLatitude(latitude) returns the grid size (in meters) from the precision of the latitude .

sagarpreet-chadha commented 5 years ago

Hi @jywarren , The Jasmine framework is set here 😄 . I have written the tests as well . Kindly review it . Also if it is good to go , lets release this to npm as well ❓ So that i can integrate it to LBL 😃 🎈 . Thanks !

jywarren commented 5 years ago

Ah cool!!! Could you just quickly change dist/Leaflet.BlurredLocation.js to dist/BlurredLocation.js before publishing?

Thanks!!

On Mon, Apr 1, 2019, 7:43 AM Sagarpreet Chadha notifications@github.com wrote:

@sagarpreet-chadha https://github.com/sagarpreet-chadha requested your review on: #6 https://github.com/publiclab/blurred-location/pull/6 Precision helper functions created ..

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/publiclab/blurred-location/pull/6#event-2243032678, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ6lWiEdEBlDI-hwyKE6fS7jVB-WYks5vcfDcgaJpZM4b3vBc .

sagarpreet-chadha commented 5 years ago

@jywarren , it is already done in this PR :smile: !

jywarren commented 5 years ago

Great! Sorry was reading the summary from email. Looks good, thank you!!!

jywarren commented 5 years ago

Published!!!