Closed akanksha-v closed 3 years ago
@akanksha-v it is not required to open a new pr every time, you could have updated the previous one itself. Also, can you share the snapshot as how it looks after the changes
@govindgoel yes I shall take care of that from next time. Thank you so much and yes I can share the screenshot of the changes:
Hi @jywarren please review this :)
Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://code.publiclab.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly? Now that you've completed this, you can help someone else take their first step! See: Public Lab's coding community!
Well done!!!!
Would you like to try a new one? I'm wondering if we could make one for either:
FTO Authors
section -- is it the last 2 weeks?@govindgoel i don't know if you are familiar enough with the codebase to try to find starting points for these? Or perhaps someone else who's recently worked on the codebase here?
Thanks, all!!!!
@jywarren Will surely do these enhancements, opening up an issue, and will work on it. The timeframe for FTO authors I need to check and will update the same.
@jywarren Thanks for merging my pr and yes I would love to contribute more to this project. If issues are created for the above-mentioned points then I would definitely like to work upon these : )
oh that's wonderful both of you. If either of you get stuck or run out of time i'm happy to pitch in as well, don't hesitate to ping me here or in https://gitter.im/publiclab/publiclab
thank you!
On Sun, Dec 20, 2020 at 4:38 AM Akanksha Verma notifications@github.com wrote:
@jywarren https://github.com/jywarren Thanks for merging my pr and yes I would love to contribute more to this project. If issues are created for the above-mentioned points then I would definitely like to work upon these : )
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/community-toolbox/pull/413#issuecomment-748584783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J2Q4N37UZWOPT2CF2DSVXAXZANCNFSM4U7YB6WQ .
Fixes #411
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment below