search

publiclab / community-toolbox

Tools to understand and welcome people into a contributor community
https://code.publiclab.org
MIT License
142 stars 196 forks source link

New Navbar added with the logo of PublicLab #420

Closed YogeshSharma01 closed 3 years ago

YogeshSharma01 commented 3 years ago

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

welcome[bot] commented 3 years ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

govindgoel commented 3 years ago

@YogeshSharma01 Kindly share the preview of changes, is it referred to any issue kindly mention that too.

YogeshSharma01 commented 3 years ago

Hi, @govindgoel sorry for the late reply actually I was busy with my exams. Here is a short video of changes.

https://user-images.githubusercontent.com/51679200/104451321-610c9700-55c7-11eb-80b7-46eb0f7a2f3b.mov

YogeshSharma01 commented 3 years ago

Hi, @jywarren, @govindgoel I have set the size of the logo image. Please merge the PR.

daemon1024 commented 3 years ago

Hi @YogeshSharma01 , thanks for the awesome work on this. I had a few pointers, image

  1. The navbar background is not consistent with the rest of the page in dark mode.
  2. Is it possible to have the Fork me on github banner at the top of the page above navbar?
jywarren commented 3 years ago

Thank you!!! This is getting there -- i agree with @daemon1024's input, thank you!!

YogeshSharma01 commented 3 years ago

Hi, Thanks, @daemon1024 I have fixed the dark mode issue and also placed Fork me on GitHub banner at the top of the page above the navbar. DAY Mode>> Screenshot 2021-01-30 at 12 03 44 AM NIGHT Mode>> Screenshot 2021-01-30 at 12 04 00 AM

jywarren commented 3 years ago

This is really lovely!!! Thank you!! I'll go ahead and merge this now!!!

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://code.publiclab.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly? Now that you've completed this, you can help someone else take their first step! See: Public Lab's coding community!

daemon1024 commented 3 years ago

Fixed #319

jywarren commented 3 years ago

Hi @YogeshSharma01 just a quick query - I'm testing this out in GitPod and seeing the following. I ran npm install -- am I missing some step to get the navbar formatting?

image

YogeshSharma01 commented 3 years ago

Hi, @jywarren I debugged the code and found out this is an issue. The issue was introduced while resolving conflicts in the PR https://github.com/publiclab/community-toolbox/pull/422.

These are the issues that have found out.

  1. There is duplicate code for the navbar and the headings of FTO and Contributors sections.
  2. CSS file had a missing parenthesis due to which the whole page was misaligned.

These issues can be resolved easily. So, what do you suggest how do we push the changes?

jywarren commented 3 years ago

Hmm. Thank you so much for diagnosing this. If you are able to push a new PR i'd appreciate it, otherwise if you could open an issue describing this, we can see if someone else is able to make a fix. Thanks again!!!

On Fri, Mar 12, 2021 at 1:00 PM Yogesh Sharma @.***> wrote:

Hi, @jywarren https://github.com/jywarren I debugged the code and found out this is an issue. The issue was introduced while resolving conflicts in the PR #422 https://github.com/publiclab/community-toolbox/pull/422. These are the issues that have found out..

  1. There is duplicate code for the navbar and the headings of FTO and Contributors sections.
  2. CSS file had a missing parenthesis due to which the whole page was misaligned. these issues can be resolved easily. So, what do you suggest how do we push the changes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/community-toolbox/pull/420#issuecomment-797658993, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JYHD6VJXBTTC4ISWLTTDJJD5ANCNFSM4VVRBOUA .

YogeshSharma01 commented 3 years ago

Hi, @jywarren my apologies for the late reply actually because of some medical emergency I wasn't able to reply ok I'll create a new issue for this. Thanks

jywarren commented 3 years ago

I'm so sorry to hear that and best wishes. Please don't worry too much about this and be in touch when you're able to. ❤️