search

publiclab / community-toolbox

Tools to understand and welcome people into a contributor community
https://code.publiclab.org
MIT License
142 stars 196 forks source link

Language section added to home page #422

Closed YogeshSharma01 closed 3 years ago

YogeshSharma01 commented 3 years ago

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

YogeshSharma01 commented 3 years ago

Hi, @govindgoel Please review.

YogeshSharma01 commented 3 years ago

Hi, @govindgoel I have squashed the commits. Please merge the PR.

jywarren commented 3 years ago

Hi, thanks for your help! can you connect us to the issue this is addressing? And, would you be able to share a screenshot? Thanks a lot!!!

govindgoel commented 3 years ago

@jywarren closes #337 This is an enhancement feature, I think this will surely help.

YogeshSharma01 commented 3 years ago

Hi, @jywarren this is an enhancement feature as @govindgoel mentioned.

https://user-images.githubusercontent.com/51679200/106174852-7387f280-61bb-11eb-9de3-0348c97b3d0f.mov

YogeshSharma01 commented 3 years ago

https://user-images.githubusercontent.com/51679200/109194543-89d79d00-77bf-11eb-907e-f126c6d415d0.mov

YogeshSharma01 commented 3 years ago

Hi, @jywarren we are using Bootstrap 3.4.0 in our project which uses only a default color which is grey. The changes I've done are with this version only. If we need to change its color, then either we upgrade to 4.0 or manually set it. Though I think that this color is suitable as per the website. What do you say?

https://user-images.githubusercontent.com/51679200/109634134-e4317e80-7b6e-11eb-88c9-e6363f84920e.mov

jywarren commented 3 years ago

I think this looks great. The only and hopefully final change I'd ask is that we filter out null values, is that ok? Thank you so much!

YogeshSharma01 commented 3 years ago

Hi, @jywarren, in case if null, should we not add a label to the repo or some text instead? Like - NA

jywarren commented 3 years ago

Sure, but let's not use a label - just plain text like "N/A" is fine! Thanks!

On Thu, Mar 4, 2021 at 7:40 AM Yogesh Sharma notifications@github.com wrote:

Hi, @jywarren https://github.com/jywarren, in case if null, should we not add a label to the repo or some text instead? Like - NA

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/community-toolbox/pull/422#issuecomment-790589108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J5LMGV6S4BG3JTEWQDTB55T5ANCNFSM4WFHLCBA .

YogeshSharma01 commented 3 years ago

Hi, @jywarren all set, and thanks

https://user-images.githubusercontent.com/51679200/110002700-b483a180-7d3b-11eb-9f2c-b63e71af74af.mov

Please Review

jywarren commented 3 years ago

Oh, I'm sorry -- would it also be possible to move the listings to the bottom of the page? Perhaps just above "Stale Issues" or below Contributors? Thank you, I'm sorry i thought I'd made that suggestion already. Many thanks!

YogeshSharma01 commented 3 years ago

No problem sir, don't be sorry I'll set this section above the stale issues cause it would looks good at that place only as at the bottom we have dependency chart so I think we can also set it between the contributors and the dependency chart what do you think? Warm Regards, Yogesh Sharma Thanks you

On Fri, 5 Mar 2021, 21:43 Jeffrey Warren, notifications@github.com wrote:

Oh, I'm sorry -- would it also be possible to move the listings to the bottom of the page? Perhaps just above "Stale Issues" or below Contributors? Thank you, I'm sorry i thought I'd made that suggestion already. Many thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/community-toolbox/pull/422#issuecomment-791519914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMKI7YCVK32E4SJ35EKGHMTTCD7KVANCNFSM4WFHLCBA .

YogeshSharma01 commented 3 years ago

I think it should be fine between contributors and dependency chart section

On Sat, 6 Mar 2021, 10:00 yogesh sharma, lucksharma2017@gmail.com wrote:

No problem sir, don't be sorry I'll set this section above the stale issues cause it would looks good at that place only as at the bottom we have dependency chart so I think we can also set it between the contributors and the dependency chart what do you think? Warm Regards, Yogesh Sharma Thanks you

On Fri, 5 Mar 2021, 21:43 Jeffrey Warren, notifications@github.com wrote:

Oh, I'm sorry -- would it also be possible to move the listings to the bottom of the page? Perhaps just above "Stale Issues" or below Contributors? Thank you, I'm sorry i thought I'd made that suggestion already. Many thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/community-toolbox/pull/422#issuecomment-791519914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMKI7YCVK32E4SJ35EKGHMTTCD7KVANCNFSM4WFHLCBA .

YogeshSharma01 commented 3 years ago

Hi, @jywarren I have set the language section just below the contributor's section.

https://user-images.githubusercontent.com/51679200/110231922-963ac300-7f40-11eb-9b0f-1fdc166fad73.mov

jywarren commented 3 years ago

Hi! Great. Restarting the checks to try to get gitpod to pass. Thanks!!

YogeshSharma01 commented 3 years ago

Hi! Great. Restarting the checks to try to get gitpod to pass. Thanks!!

Yeah Sure.

jywarren commented 3 years ago

Hm, i'm so sorry, this is seeming to get stuck. Would you mind rebasing it and/or adding one more commit to see if we can get GitPod to go? Otherwise I can turn off the GitPod requirement as maybe I have it misconfigured. Apologies for the trouble!

YogeshSharma01 commented 3 years ago

Hi, @jywarren I think it would be stuck again with this gitpod.

govindgoel commented 3 years ago

@YogeshSharma01 it's strange that Gitpod is getting stuck can you try once with squashing all the commits then run it again.

YogeshSharma01 commented 3 years ago

I don't think squashing all the commits would work @jywarren what do you think? should I squashing all the commits and try again?

jywarren commented 3 years ago

Oh that's OK - i'll just turn off the gitpod check. Thanks!!!

jywarren commented 3 years ago

Great work! Awesome to finally see this wrapped up! Thanks for your patience and persistence!!!