Public lab dependency chart

publiclab / community-toolbox

Tools to understand and welcome people into a contributor community

https://code.publiclab.org

MIT License

142 stars 196 forks source link

Public lab dependency chart #424

Closed YogeshSharma01 closed 3 years ago

YogeshSharma01 commented 3 years ago

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

[ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
[ ] code is in uniquely-named feature branch and has no merge conflicts
[ ] PR is descriptively titled
[ ] PR body includes fixes #0000-style reference to original issue #
[ ] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

harshkhandeparkar commented 3 years ago

Can you provide a screenshot or a GIF of the browser window resizing or dev tools responsiveness test?

YogeshSharma01 commented 3 years ago

Yeah sure @HarshKhandeparkar

https://user-images.githubusercontent.com/51679200/106933897-78aaeb80-673f-11eb-8dac-08c4dde310e6.mov

daemon1024 commented 3 years ago

I think width:100%; would streamline all the contents across site since it looks a bit awkward. It is a bit subjective to let me know what y'all think.

daemon1024 commented 3 years ago

Also I believe .png files are pretty heavy on sites, If we would have a higher quality png, we may convert it to webp and this would not impact the website performance negatively.

YogeshSharma01 commented 3 years ago

Hi, @daemon1024 apologize for my late reply actually I was busy with my exams. Yes agreed with your point width of the picture should be 100% and I also convert the picture from .png to .webp. Thanks

daemon1024 commented 3 years ago

No problem @YogeshSharma01. I believe you will need convert the image file first. Just changing the extension won't help 😅. Also can you let me know the source of the file. While you are at it, it would be great if you could look at the your first comment and mention the issue number and other details there :) Thank You ☺️

YogeshSharma01 commented 3 years ago

Hi, @daemon1024 sorry for the late reply actually I was busy with my exams and now I have converted the image file. review it. Warm Regards Yogesh Sharma Thanks

jywarren commented 3 years ago

Great work!!!!