Closed Swayamsvk closed 3 years ago
Thanks for opening this pull request! Dangerbot
will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! đđđ
Hi! This looks all good, but it didn't run... odd! I wonder if it's a security feature: https://securitylab.github.com/research/github-actions-preventing-pwn-requests
So i tried adding a commit so it'd be from my account, but that didn't seem to work. I also can't open a new PR myself from your commits. âšī¸
What do you think we should do? I could copy your file and open a new one but you wouldn't get credit for it. Is there any way around this you can see?
I guess I could probably rebase it and open a new PR with the rebase?
Actually, I am dealing with this kind of issue for the first time. I read the docs and implemented it. I just want to make valuable contribution to this project. Do whatever you think is possible.And please tell me if you need me to do anything.
I am really sorry for the mistake I accidentally pushed my main branch and I was not able to restore it so I have to delete this branch
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #427@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!