search

publiclab / community-toolbox

Tools to understand and welcome people into a contributor community
https://code.publiclab.org
MIT License
140 stars 196 forks source link

Fixed Support Label link on Navbar #541

Closed PeculiarE closed 2 years ago

PeculiarE commented 2 years ago

Fixed Support Label link on Navbar Updated the file index.html for the proposed changes

Fixes https://github.com/publiclab/community-toolbox/issues/540

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

welcome[bot] commented 2 years ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

PeculiarE commented 2 years ago

Hi @TildaDares. Could you please approve the running workflows for my PR? Thank you.

PeculiarE commented 2 years ago

Hi @TildaDares. I have made another commit to fix the previously failing tests. Could you please approve the workflow once more? Thank you.

TildaDares commented 2 years ago

Hi @PeculiarE, can you remove the package-lock.json and dist/community-toolbox.js files from this PR? Thanks!

PeculiarE commented 2 years ago

Hiya @TildaDares....when I made the first commit, the tests on the PR were failing and when I checked the log, the issue was related to failure to install dependencies. I then thought it was because I didn't install the dependencies on my local and just only edited the typo on theindex.htmlfile.

So I went back to my branch on my PC, did npm install, ran the build just to be sure, and then ran tests. The tests passed but the package-lock.json and dist/community-toolbox.js files had changes. I thought that committing these changes would fix the failing tests on Github. Turns out I was wrong as the tests are still failing here on Github even though they're passing on my local machine. Do you have any idea why that is?

I have reverted the changes and removed both files from the PR as requested. I'm just puzzled why the tests didn't pass since it was only the index.htmlfile I edited.

welcome[bot] commented 2 years ago

Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://code.publiclab.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly? Now that you've completed this, you can help someone else take their first step! See: Public Lab's coding community!

TildaDares commented 2 years ago

Congratulations 🎉🎊

PeculiarE commented 2 years ago

Thank you, Tilda! 😃 🥳