search

publiclab / community-toolbox

Tools to understand and welcome people into a contributor community
https://code.publiclab.org
MIT License
140 stars 195 forks source link

Back to Top button is not static not fixed #576

Closed RaviAnand111 closed 1 year ago

RaviAnand111 commented 2 years ago

What did you see and expected to happen

  1. The back to top button is static while it should have been fixed.
  2. The icon in back to top button is not at center.
  3. In mobile view the back to top button is covering some of the text, its position has to be moved a little to right.

Please show us where to look

https://code.publiclab.org/

FireFox btt-1

https://user-images.githubusercontent.com/59113935/168275780-48798d82-ba91-4689-86f5-08cfcb194b4f.mp4

Chrome btt-3-chrome

There are some inconsistencies between browsers as it seems the icon in chrome is in center but not in firefox. But the problem of button not being fixed and covering up content in mobile view is same in both the browsers.

Hey @TildaDares @jywarren @cesswairimu, Can you please have a look and share your views. Thank You

TildaDares commented 2 years ago

Great catch @RaviAnand111. You can go ahead and open a PR for this. Thanks!

radzhiv25 commented 1 year ago

Can i work on this issue

Great catch @RaviAnand111. You can go ahead and open a PR for this. Thanks!

TildaDares commented 1 year ago

Hi @radzhiv25, please go ahead. Thank you!

vedant-z commented 1 year ago

Hi @TildaDares may I try this?

cesswairimu commented 1 year ago

hi @vedant-z, you can go ahead, thanks

vedant-z commented 1 year ago

Hey @cesswairimu I figured out I need to tweak something in here.

image

Something like changing the display to inline-block might work. Will you please suggest me something from your end?

cesswairimu commented 1 year ago

Hey @vedant-z, mmh maybe you can try putting it in the same div as footer? its a bit tough one as it seems to be working on for some browsers/OS and not for others. Were you able to replicate the issue on your end? I haven't been able to replicate it on my end, I tried with chrome and firefox on Ubuntu 20.04, and chrome on android 11.

aditi5050 commented 1 year ago

I would like to work on this issue shall I start working on it.

cesswairimu commented 1 year ago

hi @aditi5050, are you able to replicate the bug on your end? I don't see it on my end as I mentioned above https://github.com/publiclab/community-toolbox/issues/576#issuecomment-1322075767. If you are able to you can go ahead, thanks

aditi5050 commented 1 year ago

@cesswairimu yes I think the issue has been solved, I would try working on some other issues I'm sorry for engaging your time

cesswairimu commented 1 year ago

No problem @aditi5050, we appreciate your interest and we would love help your help on any other open issues. Sometimes some open issues are solved on other issues and we can only realized once we take a look again on the bug. Thanks all, closing this now.