search

publiclab / image-sequencer-app

An Image Processing server based on image-sequencer
GNU General Public License v3.0
7 stars 5 forks source link

Geotiff Module #41

Open tech4GT opened 5 years ago

tech4GT commented 5 years ago

@jywarren If you happen to have any resources regarding this, it would be really helpful. :smile:

Update: https://npmjs.com/geotiff

jywarren commented 5 years ago

Yes!

https://github.com/publiclab/mapknitter/issues/296

šŸ™ŒšŸ½

We may need to fetch the coordinates from an earlier step though, so would need to pass along metadata somehow? Or I guess we could specify it in the initial multi image steps Json.

On Sun, Mar 31, 2019, 12:29 AM Varun Gupta notifications@github.com wrote:

@jywarren https://github.com/jywarren If you happen to have any resources regarding this, it would be really helpful. šŸ˜„

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/962, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ3o45FztLKtphZnXnvQtdHNcZQMFks5vcDlugaJpZM4cUHJ2 .

tech4GT commented 5 years ago

@jywarren So the idea of a module which is non chain-able is a little weird inside of Image sequencer. I was thinking maybe this can output the same input image as far as Image-sequencer is concerned but it maybe outputs the other data as a file and saves it. What do you think?

harshkhandeparkar commented 5 years ago

Why is it non chainable? Maybe we can return a new sequencer.

jywarren commented 5 years ago

Yeah I agree, but so the idea of an output module would be one which ends the sequence. It could still output a data url, but just not one in a format that another standard module could read. Later this idea could encompass an export to svg or PDF module, for example.

On Mon, Apr 8, 2019, 4:15 AM Harsh Khandeparkar notifications@github.com wrote:

Why is it non chainable? Maybe we can return a new sequencer.

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/962#issuecomment-480731280, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJxBh8cmonyKQ0XWvosyA5CLqDUxbks5vevp4gaJpZM4cUHJ2 .

tech4GT commented 5 years ago

@jywarren hmm, Iā€™m not sure I get you completely. So I was thinking that this module can just output the input, sequencer wise but would start a file download in the browser or on the node side save a file. Is this what you are thinking too?

jywarren commented 5 years ago

I think that'll work fine, sure! In any case we will be wanting to send it to Google cloud storage so that sounds good. If we ever wanted a data-url we could do that separately.

I'm mainly suggesting a new standard mental model for the general behavior of "doing things with what image-sequencer produces", with the idea of a new type of module called an "output module", however we don't have to address this right now. Thanks!

On Mon, Apr 8, 2019, 8:56 AM Varun Gupta notifications@github.com wrote:

@jywarren https://github.com/jywarren hmm, Iā€™m not sure I get you completely. So I was thinking that this module can just output the input sequencer wise but would start a file download in the browser or on the node side save a file. Is this what you are thinking too?

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/962#issuecomment-480819953, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ3Qu4l83QRLBnYHslz695FnEb9Ubks5vezxYgaJpZM4cUHJ2 .

tech4GT commented 5 years ago

Aha got it! So this output module supposedly ends the sequence if applied right?

jywarren commented 5 years ago

Yeahhh, it's not super important but with more output module types emerging I thought it might be a good idea to create some norms around and guidance.

On Mon, Apr 8, 2019, 9:38 AM Varun Gupta notifications@github.com wrote:

Aha got it! So this output module supposedly ends the sequence if applied right?

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/962#issuecomment-480835302, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJz1GwtVTYUIjpmSHF9ZG3z_Y5bnvks5ve0ZRgaJpZM4cUHJ2 .

tech4GT commented 5 years ago

@jywarren I suppose this should be our next step??

tech4GT commented 5 years ago

I think this is all that is left as far as Image Sequencer is concerned, correct? Apart from this we have to make a converter function for the json request and implement the workflow but thats on the app, right? @jywarren

harshkhandeparkar commented 5 years ago

Hey @tech4GT I had a question, puppeteer runs a headless version of chromium right?

tech4GT commented 5 years ago

Depends, puppeteer-core can utilize whatever browser you have installed, it does not explicitly download chromium.

harshkhandeparkar commented 5 years ago

Can it be forced or add a rule to prioritize using firefox? Can it even use firefox btw?

tech4GT commented 5 years ago

@jywarren would love your input here, thanks! :smile:

jywarren commented 5 years ago

Ah, well we do need the webgl-distort module in your new gl code, so we can go through the full distortion + compositing sequence with each image, right? Thanks!

On Tue, Apr 16, 2019 at 3:41 PM Varun Gupta notifications@github.com wrote:

@jywarren https://github.com/jywarren would love your input here, thanks! šŸ˜„

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/962#issuecomment-483758013, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ7MCYmGnncBidBVhV9bUTh0ihYUOks5vhgD-gaJpZM4cUHJ2 .

tech4GT commented 5 years ago

Oh sure! Do you want me to make webgl-distort into a is-module. Actually My exams start next week so I want to get this done before that. I think we have most of the pieces, major work remains in glueing them together on the is-app, correct?

jywarren commented 5 years ago

Yes, that's right. I do think we need the webgl-distort module in order to do this... I think we could take on the remainder while you're on exams, though!

I think the Geotiff lib is less important -- it's a final export step once the rest is running. Can we get the webgl-distort working, which I think is the last major piece? Thank you!!!

On Tue, Apr 16, 2019 at 4:00 PM Varun Gupta notifications@github.com wrote:

Oh sure! Do you want me to make webgl-distort into a is-module. Actually My exams start next week so I want to get this done before that. I think we have most of the pieces, major work remains in glueing them together on the is-app, correct?

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/962#issuecomment-483821295, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ1WkccOr3B9zXwa53g6ABMFZczBkks5vhiu2gaJpZM4cUHJ2 .

tech4GT commented 5 years ago

Working on webgl-distort now!

harshkhandeparkar commented 5 years ago

@jywarren @tech4GT the geotiff module just exports the image as a .tiff right?

jywarren commented 4 years ago

I'm going to move this to image-sequencer-app!