Input coordinates clear understanding by pointer icons

aashna27 commented 5 years ago

We need to make coordinate input fields more descriptive to let the user know that values can be modified by clicking on image coordinates.

Suggestions:

use a cross hairs icon
use a mouse or finger pointer icon
while click event is active, change the cursor itself.

This is an improvement for the current open pr, #1187 and ideas are sought for better inputs.

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

jywarren commented 5 years ago

Great!! Do you think it should trigger the "choose a pixel" interface when you click the icon? And, when adding the module, should it auto click it, basically, to prompt the user initially?

On Sat, Aug 3, 2019, 12:43 PM aashna27 notifications@github.com wrote:

We need to make coordinate input fields more descriptive to let the user know that values can be modified by clicking on image coordinates.

Suggestions:

use a cross hairs icon

use a mouse or finger pointer icon

while click event is active, change the cursor itself.

This is an improvement for the current open pr, #1187 https://github.com/publiclab/image-sequencer/pull/1187 and ideas are sought for better inputs.

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

Please show us where to look

https://beta.sequencer.publiclab.org What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1193?email_source=notifications&email_token=AAAF6J7M23E3HBRXKNXNSV3QCVHKXA5CNFSM4IJCVESKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDF2LSA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J7VAW2BU3WSVK7EUGDQCVHKXANCNFSM4IJCVESA .

aashna27 commented 5 years ago

Maybe what we can do is that when the icon is clicked the image comes in focus.What say?

MargaretAN9 commented 5 years ago

Being able to identify image coordinates could also be used as part of a module to calibrate microscope images. Once the points are identified a scaling routine could be sent to the grid module as in https://publiclab.org/system/images/photos/000/025/299/original/Slide2.JPG

vaibhavmatta commented 5 years ago

Can’t we give a CROP PHOTO button just below the Initial step and make a new node.js app for cropping it? It will look much professional and easier to use.

What's your say? @jywarren @aashna27 ??

jywarren commented 5 years ago

Maybe what we can do is that when the icon is clicked the image comes in focus.What say?

What does "comes in focus" look like?

@vaibhavmatta sorry, i don't quite follow; this isn't specifically a crop issue, can you clarify, and if you'd like to open a new issue for a separate topic, please do!

vaibhavmatta commented 5 years ago

@jywarren I am talking about giving the option to crop the image. Should I open a new issue for it? I will design my own UI to address the issue. Isn't it good?

jywarren commented 5 years ago

ah, i think crop should now have this feature, shouldn't it? But, we should try to imagine the exact UI that will be standard for pixel x,y selection. I think ideally you click the icon next to the box, and you get a crosshairs cursor, and then yes, we could somehow highlight the image to prompt you to click on it?

On Thu, Aug 15, 2019 at 4:57 PM vaibhavmatta notifications@github.com wrote:

@jywarren https://github.com/jywarren I am talking about giving the option to crop the image. Should I open a new issue for it? I will design my own UI to address the issue. Isn't it good?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1193?email_source=notifications&email_token=AAAF6J27OYJUZJSRF4VWSSDQEW7ITA5CNFSM4IJCVESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4M7IGA#issuecomment-521794584, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J3ETPEPPOT4KGLT53TQEW7ITANCNFSM4IJCVESA .

vaibhavmatta commented 5 years ago

@jywarren What if the image gets highlighted as soon as User clicks Crop button and It would be easier for user if he just selects the important area out from picture instead of filling in the values of X,Y etc. . We can somehow manage to autofill the X,Y options according to user's selection.

jywarren commented 5 years ago

Ah, yes, so that would be the case upon initially adding the step, right? Yes, i think that makes sense too.

On Thu, Aug 15, 2019 at 5:07 PM vaibhavmatta notifications@github.com wrote:

@jywarren https://github.com/jywarren What if the image gets highlighted as soon as User clicks Crop button and It would be easier for user if he just selects the important area out from picture instead of filling in the values of X,Y etc. .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1193?email_source=notifications&email_token=AAAF6J7VRCU4FJ2DVL34TJLQEXAQXA5CNFSM4IJCVESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4NAC7A#issuecomment-521798012, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JYLUP476Q5ZESQVUMDQEXAQXANCNFSM4IJCVESA .

vaibhavmatta commented 5 years ago

@jywarren exactly. May I Claim it? I think I can work on it. It's a new feature and I would love to work on it.

jywarren commented 5 years ago

Sure, if Aashna is ok with it? Thank you!

On Thu, Aug 15, 2019 at 5:11 PM vaibhavmatta notifications@github.com wrote:

@jywarren https://github.com/jywarren exactly. May I Claim it? I think I can work on it. It's a new feature and I would love to work on it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1193?email_source=notifications&email_token=AAAF6J2TDA75T5HY6XVFLLLQEXA5DA5CNFSM4IJCVESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4NAKTY#issuecomment-521798991, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J6BHDAT2RFKCMHG4DLQEXA5DANCNFSM4IJCVESA .

vaibhavmatta commented 5 years ago

@jywarren Welcome Sir. Please keep in mind, my Interest and love for Publiclab. You can tag me in any issue you want me to work on. I would have pleasure in Contributing. @aashna27 please confirm. Thanks.

jywarren commented 5 years ago

Great, thank you! If you are still waiting, there are plenty of other issues you can take up as well! Have you done a first-timers-only issue yet? Thanks!

On Thu, Aug 15, 2019 at 5:15 PM vaibhavmatta notifications@github.com wrote:

@jywarren https://github.com/jywarren Welcome Sir. Please keep in mind, my Interest and love for Publiclab. You can tag me in any issue you want me to work on. I would have pleasure in Contributing. @aashna27 https://github.com/aashna27 please confirm. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1193?email_source=notifications&email_token=AAAF6J3PWE2QWX7F6JHSJITQEXBM3A5CNFSM4IJCVESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4NATYA#issuecomment-521800160, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JY734OVOOQGLTX2C2LQEXBM3ANCNFSM4IJCVESA .

vaibhavmatta commented 5 years ago

@jywarren Being bit experienced in OpenSource Contributions, I am not touching first-timers-only issues. They are meant to help first-timers to build their Confidence.

My main Aim is to contribute as much as I can to become a GSoc approved contributor.

Still if you say, I will go for them 🙂.

jywarren commented 5 years ago

well, you are welcome to do it in order to learn our particular workflow, but I also appreciate your willingness to jump in on a more challenging task! We also have "help-wanted" issues. Thanks a lot!

On Fri, Aug 16, 2019 at 11:00 AM vaibhavmatta notifications@github.com wrote:

@jywarren https://github.com/jywarren Being bit experienced in OpenSource Contributions, I am not touching first-timers-only issues. They are meant to help first-timers to build their Confidence. Still if you say, I will go for them 🙂.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1193?email_source=notifications&email_token=AAAF6J6C5JKSSRL5LPICM53QE26FRA5CNFSM4IJCVESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4O3F7I#issuecomment-522040061, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J3736LEDKJ3GYDOBGLQE26FRANCNFSM4IJCVESA .

vaibhavmatta commented 5 years ago

@jywarren, I will claim some of them 🙂.

publiclab / image-sequencer