Histogram Module is failing

ataata107 commented 4 years ago

Please describe the problem (or idea)

ezgif com-video-to-gif (5)

What did you expect to see that you didn't?

Expected for the histogram to load

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

rishabhshuklax commented 4 years ago

Hi, This is working fine in my machine

Screenshot from 2020-01-12 03-02-34

ataata107 commented 4 years ago

@blurry-x-face It is even not working on the beta site. Can you confirm that? Have you pulled the latest changes?

ataata107 commented 4 years ago

@publiclab/is-reviewers

rishabhshuklax commented 4 years ago

Just checked, you're right it is not working on beta site maybe something got updated on recent PRs, My version is maybe 2-3 commits behind. Was changePixel method changed in any of the recent PRs?

keshav234156 commented 4 years ago

@ataata107 @blurry-x-face yes there is a bug but fix doesn't seem to be correct. It's just a workaround solution @HarshKhandeparkar it's caused due to your PR . Can you please take a look at what went wrong and fix it.

harshkhandeparkar commented 4 years ago

Taking a look rn.

publiclab / image-sequencer