search

publiclab / image-sequencer

A pure JavaScript sequential image processing system, inspired by storyboards
https://sequencer.publiclab.org
GNU General Public License v3.0
110 stars 208 forks source link

changePixel called after extraManipulation #1515

Open harshkhandeparkar opened 4 years ago

harshkhandeparkar commented 4 years ago

Please describe the problem (or idea)

PixelManipulation offers two methods to manipulate the pixels, changePixel and extraManipulation. extraManipulation is supposed to be used for post-processing and is supposed to fire only after changePixel completes but this doesn't happen.

Evidence: https://github.com/publiclab/image-sequencer/pull/1458

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

ataata107 commented 4 years ago

@HarshKhandeparkar maybe we can collab on this one too?

harshkhandeparkar commented 4 years ago

Yeah. Sure.

On Thu, 16 Jan, 2020, 8:39 PM Shazeb Ata, notifications@github.com wrote:

@HarshKhandeparkar https://github.com/HarshKhandeparkar maybe we can collab on this one too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1515?email_source=notifications&email_token=AIJI5H27YRFMMFLOCKB5VATQ6B2DBA5CNFSM4KHTR7V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJEMQXY#issuecomment-575195231, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJI5HZ7HYTHALV2XU44AS3Q6B2DBANCNFSM4KHTR7VQ .

akshaygupta533 commented 4 years ago

Is anyone working on this? Can I take it up if not?

harshkhandeparkar commented 4 years ago

If no one is working on it, sure.

On Sun, 19 Jan, 2020, 6:59 PM Akshay Gupta, notifications@github.com wrote:

Is anyone working on this? Can I take it up if not?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1515?email_source=notifications&email_token=AIJI5H7ONLHWMMFYASWAX6DQ6RIT7A5CNFSM4KHTR7V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKSFQA#issuecomment-576004800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJI5H6JQ5A4YPTXW4H4OKTQ6RIT7ANCNFSM4KHTR7VQ .

ataata107 commented 4 years ago

Yup go ahead