Changing asynchronous callbacks of Sequencer Object to Promises

publiclab / image-sequencer

A pure JavaScript sequential image processing system, inspired by storyboards

https://sequencer.publiclab.org

GNU General Public License v3.0

110 stars 208 forks source link

Open rishabhshuklax opened 4 years ago

rishabhshuklax commented 4 years ago

As of now we support ES6 but we still have so many callbacks and callback hells! We should change them to Promises because promises:

*[x] Allow cleaner and better, functional code with less error-prone boilerplate
*[x] Are easy to debug
*[x] Provide catching mechanism which are not in callbacks
*[x] Promises are built over callbacks

rishabhshuklax commented 4 years ago

@publiclab/is-reviewers @jywarren @HarshKhandeparkar What are your views?

Divy123 commented 4 years ago

I think this can be a great step towards easy debugging and attaining a more managed codebase, easier to handle. What do you think @jywarren ?

Also, @blurry-x-face do you want to work on this one?

rishabhshuklax commented 4 years ago

Yes! I want to work on it!

Divy123 commented 4 years ago

I think you can go ahead after listening to @jywarren .