search

publiclab / image-sequencer

A pure JavaScript sequential image processing system, inspired by storyboards
https://sequencer.publiclab.org
GNU General Public License v3.0
110 stars 208 forks source link

Blob detection module needs a test #1587

Open jywarren opened 4 years ago

jywarren commented 4 years ago

We have an amazing OpenCV based blob detection module @aashna27 created: #1185

~Strangely it's not in the demo or the beta: https://sequencer.publiclab.org/examples/ https://beta.sequencer.publiclab.org/examples/~

~Though it definitely works in Aashna's demo: https://aashna27.github.io/image-sequencer/examples/#steps=brightness{},brightness{},blob-analysis{}~

~@aashna27 are you able to take a look to see how it got removed?~

We should add a test like this one to protect it!

https://github.com/publiclab/image-sequencer/blob/89fb3585ac082c6bce3cd72640ec2be9f75df5f0/test/core/modules/colorbar.js

Let's protect it! It's a very powerful feature 😄

jywarren commented 4 years ago

False alarm! needed to clear cache on an old browser.

https://sequencer.publiclab.org/examples/#steps=brightness{},brightness{},blob-analysis{} this works!

Changing title to be "write test for this module"

rishabhshuklax commented 4 years ago

I'll be happy to write the test for it!

rishabhshuklax commented 4 years ago

But I was having problem in running it in node, I'll try to solve that issue first!

jywarren commented 4 years ago

Thank you!!

rishabhshuklax commented 4 years ago

@jywarren PR to make it work on Node #1589, please have a look!