search

publiclab / image-sequencer

A pure JavaScript sequential image processing system, inspired by storyboards
https://sequencer.publiclab.org
GNU General Public License v3.0
110 stars 208 forks source link

"Feature maintainers" groups to collaboratively manage IS #1633

Open rishabhshuklax opened 4 years ago

rishabhshuklax commented 4 years ago

Similar to the one discussed in publiclab/plots2#6501 we should have maintainers groups in IS to collaboratively manage different features of IS this would help in maintaining the library more efficiently, Features around which we can develop a team around includes:

What do you guys think?

@publiclab/is-reviewers @publiclab/support @publiclab/mentors

cc: @jywarren

harshkhandeparkar commented 4 years ago

This is an awesome idea.

jywarren commented 4 years ago

Agreed!

harshkhandeparkar commented 4 years ago

@jywarren there are many cooked bug fix PRs which have not been merged. And you are very busy I see. Can I get temporary merge permissions to continue with the bug fix event?

jywarren commented 4 years ago

Hi @HarshKhandeparkar it has been really tough to keep up. Do we have a prioriy or urgent label you can highlight them to me on? And, you can always bump them up to me in https://gitter.im/publiclab/publiclab -- thank you so much! Hope everyone is safe and doing well. ❤️

harshkhandeparkar commented 4 years ago

I think almost all PRs are outdated and inactive at this point 😅.

jywarren commented 4 years ago

Hi @HarshKhandeparkar after #1668 perhaps we can get ahead of this again now! It dramatically simplifies the review process. Thank you and hope you're well!

jywarren commented 4 years ago

though, noting https://github.com/publiclab/image-sequencer/issues/1681 as well...

Update: fixed!! 🎉

harshkhandeparkar commented 4 years ago

It works really well!

jywarren commented 3 years ago

Thanks for all the reviews and issue cleanup!

jywarren commented 3 years ago

Ah, thought of a new one -- cli-maintainers -- pending the CLI tests in #1694

jywarren commented 3 years ago

Can folks volunteer for a specific one and we can start creating the CODEOWNERS listing? Thank you all!!!

rishabhshuklax commented 3 years ago

I could help out in maintaining modules and core functionalities, while working on #1564 I had to go through a lot of code related to these

harshkhandeparkar commented 3 years ago

definitely module and core! I love cli but idk what changes can be made to it ¯_(ツ)_/¯

jywarren commented 3 years ago

Cool, thanks both! I guess we ought to write a line of description of the "goals" and "priorities" of each. Harsh, for CLI, my thought is not every feature needs planned changes -- some can be in "maintenance" status, meaning the maintainers for that feature are primarily ensuring that it remains stable and undisrupted, and perhaps slowly increasing test coverage of it. Make sense?

Whereas the "modules" maintainers might be seeking both to increase the # of modules, and to increase stability/test coverage of existing ones -- it's up for discussion!

On Thu, Oct 1, 2020 at 3:15 PM Harsh Khandeparkar notifications@github.com wrote:

definitely module and core! I love cli but idk what changes can be made to it ¯(ツ)/¯

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1633#issuecomment-702343430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J7G3Y6B4U5WKTMPF7LSITIOTANCNFSM4KX5KBJQ .

jywarren commented 3 years ago

Awesome, @daemon1024 is working on an initial CLI test suite and is interested in being a feature maintainer for the CLI featureset, whose goal is maintain existing features and expand test suite. Awesome!

OK, if we can get some similar descriptions/goals for other featuresets, we can create the initial CODEOWNERS file. Thanks, all!

What do we think about core goals or test or module goals? I think core ought to be "stability, optimization, backwards-compatibility" maybe?

Modules... one could be "making sure it's simple to create new modules" and "standardizing module code and documentation"

Tests... maybe "ensure test parity across various use cases including CLI, Node, and browser"? and more?

harshkhandeparkar commented 3 years ago

Should we add this list of goals to the issue body?

harshkhandeparkar commented 3 years ago

Anyone here can edit and add the goals.

harshkhandeparkar commented 3 years ago

I believe core should be "stability, performance and future compatibility". I think we are just breaking IS further due to backwards compatibility and no one uses old browsers with IS anyway. And also, some parts of IS are anyway not compatible with old browsers and node <10 ig.

jywarren commented 3 years ago

Oh sorry, so this is a good reason to write these together -- i should clarify - i meant backwards compatibility as in no breaking changes and no adverse effects on existing functions, including core, modules, ui and cli. And yes, we can keep compiling these at the top!

harshkhandeparkar commented 3 years ago

@jywarren I have added some of the goals and priorities to the issue body, please check it out :)

cc: @blurry-x-face @daemon1024

harshkhandeparkar commented 3 years ago

The priorities are absolutely tentative, I just wrote whatever came to my mind.

jywarren commented 3 years ago

OK awesome i like them a lot. I propose for module goals:

GOALS: Increasing the number of modules, stability/optimization of existing modules.

to add: also, ensuring that creating new modules remains easy and accessible and well documented

And: "developing compelling use cases for sequences to show off IS functionality, as in #1480"

what do you think?

harshkhandeparkar commented 3 years ago

Sure, I'll add it.

harshkhandeparkar commented 3 years ago

Umm, should child teams of is-maintainers be made? We can add these priorities and goals there.

jywarren commented 3 years ago

Hmm, cool idea! Yes, we can do that - like is-module-maintainers, is-core-maintainers? Also, i forget if whole teams can be made CODEOWNERS...

also maybe interesting --

"round robin" auto review requests to prompt only some people in a team! https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-organizations-and-teams/managing-code-review-assignment-for-your-team=

also really nice "review request scheduling reminders" system here: https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-organizations-and-teams/managing-scheduled-reminders-for-your-team

maybe useful if teams get bigger, and/or if people don't want to be on the hook all the time but just a proportion!

On Wed, Oct 7, 2020 at 12:20 PM Harsh Khandeparkar notifications@github.com wrote:

Umm, should child teams of is-reviewers be made? We can add these priorities and goals there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1633#issuecomment-705046282, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J7NT5EPJEDWBJ4DVT3SJSINDANCNFSM4KX5KBJQ .

harshkhandeparkar commented 3 years ago

I think teams can be codeowners according to this official blog post. https://github.blog/2017-07-06-introducing-code-owners/ image That(github/js) looks like a team

jywarren commented 3 years ago

Awesome. Anyone else @publiclab/is-reviewers want to join a maintainers team? Any last changes before we start this up? Thanks!!!

On Wed, Oct 7, 2020 at 1:28 PM Harsh Khandeparkar notifications@github.com wrote:

I think teams can be codeowners according to this official blog post. https://github.blog/2017-07-06-introducing-code-owners/ [image: image] https://user-images.githubusercontent.com/34770591/95366088-9468c700-08f0-11eb-97eb-52aa0e240d06.png That(github/js) looks like a team

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1633#issuecomment-705084233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J2V7ALYZJQBF4MCJM3SJSQMRANCNFSM4KX5KBJQ .

harshkhandeparkar commented 3 years ago

If @blurry-x-face confirms the list then ig we are good to go.

rishabhshuklax commented 3 years ago

Yea @HarshKhandeparkar goals and pririties looks good to me, we can continue with this :)

jywarren commented 3 years ago

Great -- Harsh, would you like to open a PR with the CODEOWNERS file accordingly, and i can review and make the corresponding teams? Thanks, all!

On Thu, Oct 8, 2020 at 3:06 PM Rishabh Shukla notifications@github.com wrote:

Yea @HarshKhandeparkar https://github.com/HarshKhandeparkar goals and pririties looks good to me, we can continue with this :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1633#issuecomment-705764987, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JZC6PGCLK72NSYT7UDSJYESNANCNFSM4KX5KBJQ .

harshkhandeparkar commented 3 years ago

Umm. I don't exactly know what a CODEOWNERS file is :joy:.

jywarren commented 3 years ago

Ah, my apologies - the CODEOWNERS file is what drives this feature -- see this PR -- https://github.com/publiclab/plots2/pull/6502/files

Make sense? what do you think?

harshkhandeparkar commented 3 years ago

Where can I find the docs for it?

harshkhandeparkar commented 3 years ago

Actually, I don't really need to. @jywarren Can you make the teams though?

jywarren commented 3 years ago

Done! https://github.com/orgs/publiclab/teams/is-maintainers

jywarren commented 3 years ago

OK, folks, invited you too -- but i set the checks to 2 approvals required just while we try this system out. Thanks, let's take it one step at a time and we can prob lower that threshold soon.

jywarren commented 3 years ago

@tech4GT @Divy123 any interest in joining a feature maintainers team? ❤️

Divy123 commented 3 years ago

@jywarren I would be most interested but I would like to start work on the project once again first and see some of the amazing recent advancements, it has made to which I get accustomed to!!!

Thanks a lot for considering! Will love to be a part here soon!!

jywarren commented 3 years ago

Hi all! How are we feeling about the workflow, given we just published a new release, we now have a checklist for releases #1692 and we are getting ready with both a project and a milestone for v3.6.1 or v3.7.0?

Should we drop the # of reviews required down to 1? Or are we OK as it is? Also, i'll re-open this so we can recruit more maintainers and just have more dialogue. Thank you!

harshkhandeparkar commented 3 years ago

(I couldn't find a better issue to discuss this) @jywarren Can we please use a "project" instead of a milestone for v3.7.0 since a project makes it much easier to organize the issues and PRs separately and it also has multiple columns (one for issues, one for closed issues, one for PRs etc) Refer to the v3.6.1 project.

Thanks.

jywarren commented 3 years ago

Sure, i was just more familiar with milestones. Do you think all the existing entries in the v.3.7.0 milestone could go into the 3.6.1 project, and secondly, do you want to rename 3.6.1 project to 3.7.0? What are your thoughts? thanks!

harshkhandeparkar commented 3 years ago

I am ok with both.

harshkhandeparkar commented 3 years ago

I just created a sort-of template release project. image We can copy this from the menu.

jywarren commented 3 years ago

oh awesome idea!!!!

On Sun, Nov 1, 2020 at 11:55 PM Harsh Khandeparkar notifications@github.com wrote:

I just created a sort-of template release project. [image: image] https://user-images.githubusercontent.com/34770591/97831344-b7bb4200-1cf5-11eb-9314-f45682465840.png We can copy this from the menu.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/1633#issuecomment-720235176, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JYLUGQAATPYNQMC2PTSNY3VFANCNFSM4KX5KBJQ .