publiclab / image-sequencer

A pure JavaScript sequential image processing system, inspired by storyboards
https://sequencer.publiclab.org
GNU General Public License v3.0
110 stars 210 forks source link

Refine/simplify "add module" interface in demo #215

Closed jywarren closed 6 years ago

jywarren commented 6 years ago

I think it'd be better for UI consistency to have the "configure step" interface always show in the same place, so not at the moment of adding a new module, but only after you've added it. You can always delete the module if you want a different one!

This would simplify the UI a bit, like this:

screenshot 2018-04-19 at 2 12 36 pm

What do you think, @tech4GT ? Related to https://github.com/publiclab/image-sequencer/issues/197

jywarren commented 6 years ago

GitMate.io thinks possibly related issues are https://github.com/publiclab/image-sequencer/issues/122 (Simplify module requirements?), https://github.com/publiclab/image-sequencer/issues/138 (Add a Dithering module), https://github.com/publiclab/image-sequencer/issues/27 (add fisheyegl module), https://github.com/publiclab/image-sequencer/issues/142 (Add select dropdown for some module UIs in demo), and https://github.com/publiclab/image-sequencer/issues/157 (Add a Contrast module).

tech4GT commented 6 years ago

@jywarren that sound good to me, infact I have been thinking about this as well so that ui remains consistent and user can scroll down as more steps are added

tech4GT commented 6 years ago

@jywarren also I was thinking we can have a preview button, pressing which a modal appears which contains just the images through all the steps like a timeline, what say?

jywarren commented 6 years ago

I like the "timeline view" idea -- cool!

jywarren commented 6 years ago

Hmm, interesting -- looking ahead, does this simplification involve "simply" (lol) removing these lines of code?

https://github.com/publiclab/image-sequencer/blob/4d75fb9640f9f5ddf9e05ad451a2672a2bd85cb5/examples/demo.js#L171-L200

tech4GT commented 6 years ago

@jywarren I and mayank have decided to plan for the summer tomorrow, it would be great if you can join us. We can discuss all the major points..

jywarren commented 6 years ago

Oh, tomorrow may be difficult -- what time? I'm usually more free during the week. But I can try!

Can you use http://www.inyourowntime.info/ ?

tech4GT commented 6 years ago

@jywarren what will be the best suited time for you, I can adjust since it's my holiday?

jywarren commented 6 years ago

http://www.inyourowntime.info/2018-04-29_11.30_America.New_York but if it's too hard, don't worry about it, go ahead and meet w Mayank and just be sure to write up what you decide in issues! Thanks!

tech4GT commented 6 years ago

@jywarren that is totally doable😃👍

jywarren commented 6 years ago

Awesome will u be meeting in chatroom?

On Sun, Apr 29, 2018, 12:15 AM Varun Gupta notifications@github.com wrote:

@jywarren https://github.com/jywarren that is totally doable😃👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/215#issuecomment-385224383, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ-mcHoCjjFiZu15T7mS0lxlDK5xCks5ttT46gaJpZM4TcRew .

tech4GT commented 6 years ago

@jywarren what do you suggest? I was thinking hangouts?

tech4GT commented 6 years ago

@jywarren mayank and I are ready, whenever you say😄

jywarren commented 6 years ago

I'm in a noisy place actually, I'm sorry - maybe I can join for a bit on chat and you all can continue in video...

On Sun, Apr 29, 2018, 11:27 AM Varun Gupta notifications@github.com wrote:

@jywarren https://github.com/jywarren what do you suggest? I was thinking hangouts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/215#issuecomment-385259259, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJzbshuD41fiI2b02YntrelRH9jgVks5ttdu9gaJpZM4TcRew .

tech4GT commented 6 years ago

@jywarren actually mayank also cannot video call today so we all are on chat

tech4GT commented 6 years ago

@jywarren what is your hangouts email??