search

publiclab / image-sequencer

A pure JavaScript sequential image processing system, inspired by storyboards
https://sequencer.publiclab.org
GNU General Public License v3.0
110 stars 210 forks source link

Make in-browser replaceImage method work sequentially #305

Open jywarren opened 6 years ago

jywarren commented 6 years ago

It can hog all the CPU, so we should have the default be that it does images one at a time, although it could be overridden with a parameter to be asynchronous too.

This'll be better once we have #159 workerized processes, i think?

gitmate[bot] commented 6 years ago

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/40 (chainable methods), https://github.com/publiclab/image-sequencer/issues/147 (replaceImage() returns error), and https://github.com/publiclab/image-sequencer/issues/32 (create a replaceImage() method that uses all the current steps to process and replace an image in the DOM).

gitmate[bot] commented 6 years ago

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/40 (chainable methods), https://github.com/publiclab/image-sequencer/issues/147 (replaceImage() returns error), and https://github.com/publiclab/image-sequencer/issues/32 (create a replaceImage() method that uses all the current steps to process and replace an image in the DOM).

Mridul97 commented 6 years ago

I would like to take up this issue but I would need some guidance. Could you please guide me a little here. Thanks

jywarren commented 6 years ago

@tech4gt maybe you have an idea about this?

On Sat, Sep 1, 2018 at 9:49 AM Mridul97 notifications@github.com wrote:

I would like to take up this issue but I would need some guidance. Could you please guide me a little here. Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/305#issuecomment-417861046, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ3TIAAH-EQGMjAHLbtUyRd0PpgOGks5uWpBZgaJpZM4VUvw6 .

tech4GT commented 6 years ago

Can you please elaborate on this issue, I didn't quite get it from the description. Sorry.😅

jywarren commented 6 years ago

Ah, when it's run in a browser on a whole selection of different images, they all begin processing at once. I think it may be better for browser freezing if we only do 10x at a time, and queue the remainder, so the browser doesn't try to process 100 or 200 images at the same time, you know?

On Tue, Sep 4, 2018 at 6:10 PM Varun Gupta notifications@github.com wrote:

Can you please elaborate on this issue, I didn't quite get it from the description. Sorry.😅

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/305#issuecomment-418534244, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ7wwJJng2mEike3O2_atvlw8usrAks5uXvougaJpZM4VUvw6 .

tech4GT commented 6 years ago

Aha! Got it!! I would have to think this one through! Hmm this is interesting.

jywarren commented 6 years ago

We could just add them to an array, and then have the script pick off X items from the array to process, where when each process finishes, it goes back to fetch a new one from the array?

Divy123 commented 5 years ago

@jywarren @tech4GT can I please take up this issue?