search

publiclab / image-sequencer

A pure JavaScript sequential image processing system, inspired by storyboards
https://sequencer.publiclab.org
GNU General Public License v3.0
110 stars 208 forks source link

[suggestion] Add Dark theme #851

Open avsingh999 opened 5 years ago

avsingh999 commented 5 years ago

Please describe the problem (or idea)

I have an idea Dark theme for image-sequencer.It would be better UI. I have also oppend same issue for community toolbox https://github.com/publiclab/community-toolbox/issues/155.

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

Please show us where to look

http://sequencer.publiclab.org...

What's your PublicLab.org username?

singhav

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

avsingh999 commented 5 years ago

@publiclab/mentors @jywarren @tech4GT @SidharthBansal What do you think about this I have also opened the same issue in community toolbox. Please review me. thanks : )

Divy123 commented 5 years ago

@avsingh999 can you please provide a mockup for this?

harshithpabbati commented 5 years ago

I guess we can add it as a option. So that the user chooses the one(dark mode or normal)

harshkhandeparkar commented 5 years ago

I guess we can add it as a option. So that the user chooses the one(dark mode or normal)

That is good. But actually implementing dark mode will be difficult since we use bootstrap as our frontend framework. Will we have to override almost all the bootstrap classes ?

avsingh999 commented 5 years ago

@HarshKhandeparkar Yes, It would be difficult. Let's see for other reviews.

jywarren commented 5 years ago

I think there are bootstrap themes... Maybe there's a dark theme?

On Wed, Mar 13, 2019, 7:28 AM Avkaran Singh notifications@github.com wrote:

@HarshKhandeparkar https://github.com/HarshKhandeparkar Yes, It would be difficult. Let's see for other reviews.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/851#issuecomment-472384297, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ5UF7_WDdqfZxbsKNoTgXsZfpv1Sks5vWOCqgaJpZM4brDDR .

avsingh999 commented 5 years ago

@jywarren maybe But I search and I found it's may be helpful https://bootswatch.com/darkly/ for this. thanks : )

harshkhandeparkar commented 5 years ago

Hi everyone I found some cool bootswatch dark themes:

cc @jywarren @publiclab/is-reviewers @avsingh999

jywarren commented 5 years ago

:-) cool!!!! awesome!

On Mon, Apr 8, 2019 at 2:35 PM Harsh Khandeparkar notifications@github.com wrote:

Hi everyone I found some cool bootswatch dark themes:

cc @jywarren https://github.com/jywarren @publiclab/is-reviewers https://github.com/orgs/publiclab/teams/is-reviewers @avsingh999 https://github.com/avsingh999

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/851#issuecomment-480952336, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ54ZyCFXc-ZPfaiexKXhur43g8Dyks5ve4vSgaJpZM4brDDR .

harshithpabbati commented 5 years ago

@jywarren what is your thought on making the whole UI to react??

jywarren commented 5 years ago

:-) I think it's a positive direction -- but I really want to stabilize the existing system as much as possible so that some real-world use cases can be launched, before taking on a major UI refactoring. I'll write back soon to your question about UI tests, but I think that has to be part of it too! Thank you!!!

On Mon, Apr 8, 2019 at 2:55 PM Harshith pabbati notifications@github.com wrote:

@jywarren https://github.com/jywarren what is your thought on making the whole UI to react??

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/851#issuecomment-480960423, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ67mIlLZllpcPhZkkeHGiaEHEhYZks5ve5CTgaJpZM4brDDR .

vivek-30 commented 3 years ago

@HarshKhandeparkar i have solved this issue so, can i open a PR for it ?

harshkhandeparkar commented 3 years ago

Go for it!

vivek-30 commented 3 years ago

Ok. And thank-you 😊