search

publiclab / infragram

A minimal core of the Infragram.org project in JavaScript
https://infragram.org/sandbox/
GNU General Public License v2.0
46 stars 165 forks source link

Empty paragraph tag in index.html #314

Closed girija0707 closed 1 year ago

girija0707 commented 2 years ago

The paragraph tag is empty and hence can also be removed Screenshot_2022-04-04-00-54-20-33_6012fa4d4ddec268fc5c7112cbb265e7

girija0707 commented 2 years ago

@TildaDares would like to remove it to make make the code cleaner

TildaDares commented 2 years ago

Hi @girija0707, go ahead! Thanks

jywarren commented 2 years ago

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

TildaDares commented 2 years ago

Hi @girija0707, would you like to make a first-timers issue from this? I can help with that if you're interested.

girija0707 commented 2 years ago

Hi @girija0707, would you like to make a first-timers issue from this? I can help with that if you're interested.

yes @TildaDares ,would love to do that, will you please help with the template

TildaDares commented 2 years ago

@girija0707 All you have to do is find the New Issue button and click it. After clicking you’ll find FTO template.

girija0707 commented 2 years ago

@girija0707 All you have to do is find the New Issue button and click it. After clicking you’ll find FTO template.

Ok thank you

sainamercy commented 2 years ago

@TildaDares I've checked the file regarding this issue and there's one empty "p" tag. Can I create a first-timer-issue out of this

TildaDares commented 2 years ago

Hi @sainamercy, yes you can. Thank you!

abhayvershwal commented 1 year ago

@jywarren @TildaDares This issue can be closed as it is already resolved in https://github.com/publiclab/infragram/pull/477

abhayvershwal commented 1 year ago

Duplicate issue: https://github.com/publiclab/infragram/issues/474

TildaDares commented 1 year ago

Thank you @abhayvershwal. Closing now!