publiclab / infragram

A minimal core of the Infragram.org project in JavaScript
https://infragram.org/sandbox/
GNU General Public License v2.0
44 stars 166 forks source link

Non-functionality section #infragram #322

Open stylebytemi opened 2 years ago

stylebytemi commented 2 years ago

Zone-last of the toolbar Div is non-functional. Kindly debug. Infragram FTO Issue by Temiloluwa Adewale 2 Infragram FTO Issue by Temiloluwa Adewale

welcome[bot] commented 2 years ago

Thanks for opening your first issue here! Please follow the issue template to help us help you šŸ‘šŸŽ‰šŸ˜„ If you have screenshots to share demonstrating the issue, that's really helpful! šŸ“ø You can make a gif too!

stylebytemi commented 2 years ago

@TildaDares Can I fix an issue created by me? If yes, kindly preview.

TildaDares commented 2 years ago

Hi @stylebytemi, yes you can fix an issue opened by you.

Iā€™m not sure I understand what you mean by zone-last. Can you explain it to me?

stylebytemi commented 2 years ago

The class of the div in question is "zone last" @TildaDares

stylebytemi commented 2 years ago

Hello Miss Tilda, I have fixed the issue but I would like to know what branch to push to. @TildaDares

TildaDares commented 2 years ago

@stylebytemi The command is git push --set-upstream origin <branch name>

jywarren commented 2 years ago

Hi @stylebytemi i believe that's the area that the various "Save" options are supposed to appear in. Try uploading an image and then the buttons should appear.

However when we redesign this for a full-width layout, it'll be easier to show this, and the extra buttons will be less likely to wrap onto the next line. But do you think perhaps we should show a non-enabled "Save" button? I had thought perhaps just don't show anything makes sense until there's something to do with it... a greyed out button could be confusing? But I'm not sure, and open to ideas.

stylebytemi commented 2 years ago

Thank you for your time @TildaDares I will push soon. @jywarren Thanks for your reply. Leaving it blank keeps user's eyes off as there's a probability a user won't notice the popup when an image is uploaded. I have made it easy for the buttons to fit in, I will post a screenshot here after submission.

Do have a good night.