publiclab / infragram

A minimal core of the Infragram.org project in JavaScript
https://infragram.org/sandbox/
GNU General Public License v2.0
44 stars 166 forks source link

moved index2.html to /v2/index.html #458

Closed Forchapeatl closed 2 years ago

Forchapeatl commented 2 years ago

moved index2.html to /v2/index.html

Fixes #418

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

gitpod-io[bot] commented 2 years ago

Forchapeatl commented 2 years ago

@jywarren , please how may I relate the path of these files after moving index2.html to v2/index.html ? image

jywarren commented 2 years ago

Hi! Take a look at this example!

https://github.com/publiclab/infragram/blob/Forchapeatl-patch-13/vr/index.html#L19

jywarren commented 2 years ago

Ok I think you need to adjust the test paths too now!

jywarren commented 2 years ago

Good work though!!

Forchapeatl commented 2 years ago

Thank you @jywarren ,Please what should I do about the bootstrap problem? When I includes it shader files(WebGL) do not lot. If I exclude it the UI will get destroyed.

I was thinking of including the shader* files in our v2 directory.

. ├── ... ├── v2
│ ├── index.html │ │── dist
│ │──── shader.frag │ └──── shader.vert
└── ...

jywarren commented 2 years ago

Ah, sorry i missed that question. See how in these examples, we made the path to those files settable using configuration options? https://github.com/publiclab/infragram/blob/5ff8f3fce06410c7729a77fc00e0cc9668462554/vr/index.html#L184-L185

That should work! Yes, we encountered this same issue before for those versions!

Forchapeatl commented 2 years ago

Thank you @jywarren . May I have permission to merge ?

jywarren commented 2 years ago

Great. Let's be sure @stephaniequintana knows we've moved the file!

jywarren commented 2 years ago

I approved so go ahead!!