search

publiclab / inline-markdown-editor

An inline wysiwyg markdown document editor based on replacing string subsections. WYSIWYG possible via woofmark.
https://publiclab.github.io/inline-markdown-editor/examples/
GNU General Public License v3.0
31 stars 37 forks source link

fixed deps git protocol #145

Open jywarren opened 2 years ago

jywarren commented 2 years ago

Lets upgrade editor to 3.1.0 to resolve:

https://github.com/publiclab/inline-markdown-editor/blob/12b3d1a6bd510115e98bdf8c2285173150b67d55/package-lock.json#L4947

jywarren commented 2 years ago

Hmm... ok its very close to this issue: https://github.com/actions/setup-node/issues/214

jywarren commented 2 years ago

a5ccf9a resulted in an endless loop of tests oddly. Trying node 16 instead...

jywarren commented 2 years ago

node 16 worked but went into endless test loop.

jywarren commented 2 years ago

Solved recursive issue. Now getting:

12 specs in 0.[31](https://github.com/publiclab/inline-markdown-editor/runs/5602541469?check_suite_focus=true#step:7:31)4s.
>> 0 failures
Fatal error: Callback must be a function. Received undefined
Error: Process completed with exit code 3.

Prev this didn't happen:

https://github.com/publiclab/inline-markdown-editor/runs/2969361193?check_suite_focus=true

jywarren commented 2 years ago

Unfortunately i think we may have an incorrectly written function somewhere in out tests? I'm not sure. Compare to similar error in this: https://stackoverflow.com/questions/36514468/jasmine-throws-one-error-error-timeout-async-callback-was-not-invoked#36514646

jywarren commented 2 years ago

Noting that in plots2:

However I'm not seeing this error in other recent plots2 PRs... very strange. So maybe we can drop this for now?

https://github.com/publiclab/plots2/pull/10768#issuecomment-1072528207

TildaDares commented 2 years ago

@jywarren Can you try adding a callback done to this function and calling it? https://github.com/publiclab/inline-markdown-editor/blob/12b3d1a6bd510115e98bdf8c2285173150b67d55/spec/javascripts/replacement_spec.js#L3

jywarren commented 2 years ago

@jywarren Can you try adding a callback done to this function and calling it?

https://github.com/publiclab/inline-markdown-editor/blob/12b3d1a6bd510115e98bdf8c2285173150b67d55/spec/javascripts/replacement_spec.js#L3

Thank you I'll try that!

jywarren commented 2 years ago

Hmm, i don't know why the Github Actions CI run isn't going, but i tried it manually in gitpod and got:

12 specs in 0.002s.
>> 0 failures
Fatal error: Callback must be a function. Received undefined

... so same issue. This is lower priority now but pretty annoying!

TildaDares commented 2 years ago

@jywarren You didn’t add the done callback to the function declaration on line 3.

jywarren commented 2 years ago

Just noting that we're getting a recursive loop of the tests running. Maybe we can search for this kind of error in the Jasmine forums or on StackOverflow.