search

publiclab / inline-markdown-editor

An inline wysiwyg markdown document editor based on replacing string subsections. WYSIWYG possible via woofmark.
https://publiclab.github.io/inline-markdown-editor/examples/
GNU General Public License v3.0
31 stars 37 forks source link

Delete bower.json #152

Open aditi5050 opened 1 year ago

aditi5050 commented 1 year ago

Issue Remove bower #35

welcome[bot] commented 1 year ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

jywarren commented 1 year ago

Thank you, this looks great!

govindgoel commented 1 year ago

@aditi5050 Tests seems to be failing

jywarren commented 1 year ago

Yes, i had gotten:

npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t git://github.com/jywarren/woofmark.git
npm ERR! fatal: unable to connect to github.com:
npm ERR! github.com[0: 140.82.112.4]: errno=Connection timed out
npm ERR! exited with error code: 128

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-01-2[7](https://github.com/publiclab/inline-markdown-editor/actions/runs/4028166402/jobs/6924750764#step:5:8)T21_11_49_[8](https://github.com/publiclab/inline-markdown-editor/actions/runs/4028166402/jobs/6924750764#step:5:9)48Z-debug.log
Error: Process completed with exit code 1.

I believe this is because the woofmark library is defined in the git:// protocol and will try to fix it.

jywarren commented 1 year ago

I will bump the PublicLab.Editor library to 3.1.1, and I believe that will work.

jywarren commented 1 year ago

Hmm, ok, was able to get past the git:// error but we are now seeing all tests pass and yet they get stuck in some kind of recursive loop running over and over: https://github.com/publiclab/inline-markdown-editor/actions/runs/4149410625/jobs/7178357164#step:7:475