search

publiclab / inline-markdown-editor

An inline wysiwyg markdown document editor based on replacing string subsections. WYSIWYG possible via woofmark.
https://publiclab.github.io/inline-markdown-editor/examples/
GNU General Public License v3.0
30 stars 37 forks source link

Refactor and modularize `processSection.js` #71

Open rexagod opened 5 years ago

rexagod commented 5 years ago

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @jywarren to get it labelled. Or, if this is not your first time, try to solve it yourself!

To complete this PR, we want you to convert processSection.js into smaller modules and then make use of those inside it. We'd also like if you could, along the way make some refactors such as reducing the numbers of params passed to a function by encapsulating them into an object with similar props and accessing it accordingly. A good place to start doing this is

https://github.com/publiclab/inline-markdown-editor/blob/c6342531174ee9dd92538ae63efc1e303cc7e842/src/processSection.js#L64-L65

Also, please don't hesitate to ping me, or @jywarren to help you if you're stuck anywhere!

Thanks! 🎉

aditi5050 commented 1 year ago

Hello, @rexagod I would like to work on this issue can you please assign this to me.