search

publiclab / leaflet-blurred-location-display

A library to display points which have been "blurred" for privacy with leaflet-blurred-location
https://publiclab.github.io/leaflet-blurred-location-display/examples/index.html
GNU General Public License v3.0
11 stars 12 forks source link

Add google api stub for geocoder #93

Closed nstjean closed 4 years ago

nstjean commented 4 years ago

This solves the errors when it tried to bump LBL to 1.6.0 in #92

welcome[bot] commented 4 years ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

nstjean commented 4 years ago

In LBL 1.6.0 the API got changed (by me) to the client-side version rather than the server-side version. There were no issues with the pages running, but it's causing a mess with the tests!

nstjean commented 4 years ago

This may not be necessary anymore, see my comments on https://github.com/publiclab/leaflet-blurred-location/pull/235#issuecomment-576817901

jywarren commented 4 years ago

Should we merge it anyways? Or hold off?

nstjean commented 4 years ago

I'd like to hold off and merge in the bumped LBL with change and see what happens.

nstjean commented 4 years ago

This is solved in https://github.com/publiclab/leaflet-blurred-location-display/pull/95