publiclab / leaflet-blurred-location-display

A library to display points which have been "blurred" for privacy with leaflet-blurred-location
https://publiclab.github.io/leaflet-blurred-location-display/examples/index.html
GNU General Public License v3.0
11 stars 12 forks source link

Add list of users to popup for grid squares #98

Closed jywarren closed 4 years ago

jywarren commented 4 years ago

You can now see this library on by default at:

https://stable.publiclab.org/map#7/41.14399650184958/-71.81762695312501

I'd like to suggest we list the people in the grid square when you click it. RIght now it just says "Number of Markers" but we should show a list of usernames, each linking to the corresponding profile URL like: https://publiclab.org/profile/<USERNAME>

image

Here is the code which generates this popup:

https://github.com/publiclab/leaflet-blurred-location-display/blob/b46195a8b407ed55cf41801a5c4fe6f3085d61fa/src/ui/gridCenterRectangle.js#L88

While we're at it, let's remove the "precision" line from the regular marker popup too: https://github.com/publiclab/leaflet-blurred-location-display/blob/b46195a8b407ed55cf41801a5c4fe6f3085d61fa/src/blurredLocationDisplay.js#L163

We'll also have to adjust the corresponding test, here: https://github.com/publiclab/leaflet-blurred-location-display/blob/ab0774f0fd15fe1e51b3c04acdca6531136622df/spec/javascripts/fixtures/example.html#L405

We'd love help with this!

jywarren commented 4 years ago

Working on this in #101 !