search

publiclab / leaflet-blurred-location

A Leaflet-based interface for selecting a "blurred" or low-resolution location, to preserve privacy
https://publiclab.github.io/leaflet-blurred-location/examples/
GNU General Public License v3.0
35 stars 32 forks source link

FIX: Auto-locate me button multiple spinners #234

Closed VladimirMikulic closed 4 years ago

VladimirMikulic commented 4 years ago

Demo

On the demo, you can't see me clicking "Don't allow" on Firefox popup, my screen recorder doesn't capture them for some reason. You can see me moving the cursor from the button and clicking on "empty page", but it's actually Don't allow" button on the popup.

Resolves https://github.com/publiclab/plots2/issues/7305

welcome[bot] commented 4 years ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

VladimirMikulic commented 4 years ago

Initially, an arrow function was the problem, but now when I fixed it tests are successful on localhost but they fail in Travis.

VladimirMikulic commented 4 years ago

@jywarren we can merge this :)

VladimirMikulic commented 4 years ago

@sagarpreet-chadha this is ready. Could you please review this? Thanks.

VladimirMikulic commented 4 years ago

@sagarpreet-chadha done :)

welcome[bot] commented 4 years ago

Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://publiclab.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly? Now that you've completed this, you can help someone else take their first step! See: Public Lab's coding community!

sagarpreet-chadha commented 4 years ago

Awesome thanks!!!