search

publiclab / leaflet-environmental-layers

Collection of different environmental map layers in an easy to use Leaflet library, similar to https://github.com/leaflet-extras/leaflet-providers#leaflet-providers
https://publiclab.github.io/leaflet-environmental-layers/example/
GNU General Public License v3.0
99 stars 77 forks source link

Planning Overview #1

Closed sagarpreet-chadha closed 5 years ago

sagarpreet-chadha commented 6 years ago

Plots2 issue : https://github.com/publiclab/plots2/issues/2486

Layers to include

Layer submission

We should create a clear process for:

  1. requesting a new layer
  2. collecting links and docs, and
  3. adding it to the library in a consistent way

UI/Navigation

I have implemented a search-bar feature on https://publiclab.org/people/ . Note that the search-bar 🔍 searches the people on map and not a particular location/place on map ! (https://github.com/publiclab/plots2/issues/2582)

Testing :

🔜

Release :

🔜

jywarren commented 6 years ago

Great -- can you link to the example search feature you put together, and note that it's for re-centering the map, not searching for content on the map?

Also the relative issue links won't work so i fixed it by adding https://github.com/publiclab/plots2 before the #

jywarren commented 6 years ago

Added a couple more layers and then links to APIs and libraries. Great!

jywarren commented 6 years ago

What do you think?

jywarren commented 6 years ago

This is looking awesome btw!

sagarpreet-chadha commented 6 years ago

Hi @jywarren ! Kindly have a look at https://publiclab.github.io/leaflet-environmental-layers/example/mapSimple.html . Completed JusticeMap layer :)

screen shot 2018-05-25 at 2 10 30 am
jywarren commented 6 years ago

Amazing!!! !!!!! So great. I love this.

Just a thought about the SkyTruth alerts -- i think they may be getting truncated? See how they seem to be on a grid - are we losing precision?

leaflet

Also can we make the demo full window size?

jywarren commented 6 years ago

We may need to think about a more sophisticated UI for turning on/off layers and having explanations for what they are! Let's do this much later though :-)

sagarpreet-chadha commented 6 years ago

The markers are getting removed due to : https://github.com/publiclab/leaflet-environmental-layers/blob/c4e112f6ae0a2adf2414d6678e61914d29c89106/src/skyTruthLayer.js#L87

I guess i should turn this listener off . Will make the changes ASAP 👍 !
Thanks 😄 !

jywarren commented 6 years ago

But do you see what i mean about precision? If they've been truncated, they might appear on a kind of grid at that lower resolution - like if 14.103251 became 14.10 for example.

Awesome! Also adding a note to try linking public comments map via Scott Eustis (i'll add more detail later)

sagarpreet-chadha commented 6 years ago

Oh i missed your point earlier ... Yes the markers seems to appear on a grid . Will look at it . Thanks !

sagarpreet-chadha commented 6 years ago

Great catch @jywarren 🎉 !!! Yes i was using parseInt() to truncate the precision . Done the changes 🔨 , kindly have a look !

jywarren commented 6 years ago

works perfectly. Great work and I'm seeing wind data too! :-)))

sagarpreet-chadha commented 6 years ago

Hi @jywarren ! There are 2 PR's for mapknitter and toxicRelease Inventory . Currently working on fastTracker Layer (figuring out the API as of now) . What should we do next ?

jywarren commented 6 years ago

We got an inquiry about PurpleAir air quality sensors. I think Wunderground has a data layer for air quality -- they may also have higher resolution wind data. So maybe,

Also, we can skim through the Public Lab site for posts about map databases. Marlokeno may have great ideas:

https://publiclab.org/questions/marlokeno/09-02-2017/how-can-the-public-find-or-make-maps-of-the-polluters-next-door

More here too!

https://publiclab.org/questions/warren/02-01-2018/is-there-a-way-to-view-epa-s-toxics-release-inventory-on-a-map-or-by-location

Leave some comments maybe?

On Thu, Jun 14, 2018 at 1:54 AM Sagarpreet Chadha notifications@github.com wrote:

Hi @jywarren https://github.com/jywarren ! There are 2 PR's for mapknitter and toxicRelease Inventory . Currently working on fastTracker Layer (figuring out the API as of now) . What should we do next ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/leaflet-environmental-layers/issues/1#issuecomment-397191021, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ5_YYXXQsNKoB2EHT3u0vbpIGAyGks5t8gh7gaJpZM4TsJIO .

sagarpreet-chadha commented 6 years ago

mapknitter layer and ToxicRelease Layer pushed to gh-pages branch .

sagarpreet-chadha commented 6 years ago

@jywarren Wunderground API shows same data as OpenWeatherMap API . What do you think ?

This is the current OpenWeatherMap Layer we have : Solved in this commit : f38d59419c4e88af855ec2172c1b5b44192a8be3 (Did not made a separate PR for this Layer ! )

screen shot 2018-06-26 at 4 28 45 pm
jywarren commented 6 years ago

OK, sounds good. I was just wondering if there's any higher resolution wind data out there, but that sounds fine!

On Tue, Jun 26, 2018 at 7:03 AM Sagarpreet Chadha notifications@github.com wrote:

@jywarren https://github.com/jywarren Wunderground API shows same data as OpenWeatherMap API . What do you think ?

This is the current OpenWeatherMap Layer we have : Solved in this commit : f38d594 https://github.com/publiclab/leaflet-environmental-layers/commit/f38d59419c4e88af855ec2172c1b5b44192a8be3 (Did not made a separate PR for this Layer ! )

[image: screen shot 2018-06-26 at 4 28 45 pm] https://user-images.githubusercontent.com/14952645/41907381-4d59cb6c-795e-11e8-8b92-0f8bde2bbac6.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/leaflet-environmental-layers/issues/1#issuecomment-400268121, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJwqJ5mjkhJvmPOiV7xWKPbFCKqfWks5uAhTggaJpZM4TsJIO .

sagarpreet-chadha commented 6 years ago

@jywarren ...to get data from epa site , we have to contact them .

ALSO we can show Power , Telecom , Petroleum , Water layers from https://openinframap.org/#4/46.68/-87.98/Water

What do you think ?

jywarren commented 6 years ago

Hi, which EPA site and which API? The EPA is not a good agency right now, with the current leadership, so we will not likely get cooperation. But there are other organizations "mirroring" EPA data that we may be able to rely on.

On Sun, Jul 1, 2018, 3:13 AM Sagarpreet Chadha notifications@github.com wrote:

@jywarren https://github.com/jywarren ...to get data from epa site , we have to contact them .

ALSO we can show Power , Telecom , Petroleum , Water layers from https://openinframap.org/#4/46.68/-87.98/Water

What do you think ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/leaflet-environmental-layers/issues/1#issuecomment-401588575, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJwTzZ0Ob69Fqzxhx50nn5dx3fHsyks5uCHZngaJpZM4TsJIO .

jywarren commented 6 years ago

Openinframap sounds interesting! Where does their data come from?

On Sun, Jul 1, 2018, 8:07 AM Jeffrey Warren jeff@unterbahn.com wrote:

Hi, which EPA site and which API? The EPA is not a good agency right now, with the current leadership, so we will not likely get cooperation. But there are other organizations "mirroring" EPA data that we may be able to rely on.

On Sun, Jul 1, 2018, 3:13 AM Sagarpreet Chadha notifications@github.com wrote:

@jywarren https://github.com/jywarren ...to get data from epa site , we have to contact them .

ALSO we can show Power , Telecom , Petroleum , Water layers from https://openinframap.org/#4/46.68/-87.98/Water

What do you think ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/leaflet-environmental-layers/issues/1#issuecomment-401588575, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJwTzZ0Ob69Fqzxhx50nn5dx3fHsyks5uCHZngaJpZM4TsJIO .

sagarpreet-chadha commented 6 years ago

Its part of https://www.openstreetmap.org .....hence data is crowdsourced .

By and large, this data isn't exposed on the main OSM map, so I built Open Infrastructure Map to visualise it. Source : https://openinframap.org/about.html

jywarren commented 6 years ago

Wow, ok! Let's do it!

On Sun, Jul 1, 2018, 12:59 PM Sagarpreet Chadha notifications@github.com wrote:

Its part of https://www.openstreetmap.org .....hence data is crowdsourced .

By and large, this data isn't exposed on the main OSM map, so I built Open Infrastructure Map to visualise it. Source : https://openinframap.org/about.html

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/leaflet-environmental-layers/issues/1#issuecomment-401619075, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ_foU3czIuiMujbpev_wPPOQAVWNks5uCP-7gaJpZM4TsJIO .

jywarren commented 6 years ago

Great find and great idea! Maybe we should ping @numeroteca on PublicLab.org for more data like this because he's into tracking landfills...

On Sun, Jul 1, 2018, 1:09 PM Jeffrey Warren jeff@unterbahn.com wrote:

Wow, ok! Let's do it!

On Sun, Jul 1, 2018, 12:59 PM Sagarpreet Chadha notifications@github.com wrote:

Its part of https://www.openstreetmap.org .....hence data is crowdsourced .

By and large, this data isn't exposed on the main OSM map, so I built Open Infrastructure Map to visualise it. Source : https://openinframap.org/about.html

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/leaflet-environmental-layers/issues/1#issuecomment-401619075, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ_foU3czIuiMujbpev_wPPOQAVWNks5uCP-7gaJpZM4TsJIO .

sagarpreet-chadha commented 6 years ago

I was reading about EPA and it makes sense that we will not get any help from them . I have searched for sites that mirror the data but couldn't find any that we can use .

Thanks ! Asking on Publiclab.org .

jywarren commented 6 years ago

Hi, @sagarpreet-chadha there seems to be some code samples here for the first EPA dataset: https://www.epa.gov/waterdata/navigation-delineation-service for watersheds... take a look?

jywarren commented 6 years ago

Ah, i'll share over here: https://publiclab.org/questions/sagarpreet/07-01-2018/what-more-data-layers-can-we-show-on-map

sagarpreet-chadha commented 6 years ago

Okay great ! Looking at the code samples 👍 .

jywarren commented 5 years ago

Closing in favor of #134