search

publiclab / leaflet-environmental-layers

Collection of different environmental map layers in an easy to use Leaflet library, similar to https://github.com/leaflet-extras/leaflet-providers#leaflet-providers
https://publiclab.github.io/leaflet-environmental-layers/example/
GNU General Public License v3.0
99 stars 77 forks source link

Popup sizing can make the map jump around #287

Open jywarren opened 4 years ago

jywarren commented 4 years ago

It looks like some popups are just getting really long and this is making our maps jump around a bit; you can see this happen on this page:

https://publiclab.org/wiki/sandbox-3

What are some options to solve this? Could we:

  1. have the popups not move the map
  2. make popups wider, esp. if they have tons of content (this might be a layer-by-layer thing, because in this example, the PFAS layer seems to be the worst)
jywarren commented 4 years ago

image

image

mmnoo commented 4 years ago

... or hide extra popup content behind a 'show more' link/button?

jywarren commented 4 years ago

nice!

On Tue, Nov 26, 2019 at 4:17 PM Melissa Nunes notifications@github.com wrote:

... or hide extra popup content behind a 'show more' link/button?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/leaflet-environmental-layers/issues/287?email_source=notifications&email_token=AAAF6J324QAQR6NOYEN2XXTQVWG5LA5CNFSM4JR54672YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHO22Q#issuecomment-558820714, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J77J32L6XWDXPYAVXDQVWG5LANCNFSM4JR5467Q .

sagarpreet-chadha commented 4 years ago

Yes awesome!

On Wed, 27 Nov 2019, 03:00 Jeffrey Warren, notifications@github.com wrote:

nice!

On Tue, Nov 26, 2019 at 4:17 PM Melissa Nunes notifications@github.com wrote:

... or hide extra popup content behind a 'show more' link/button?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/publiclab/leaflet-environmental-layers/issues/287?email_source=notifications&email_token=AAAF6J324QAQR6NOYEN2XXTQVWG5LA5CNFSM4JR54672YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHO22Q#issuecomment-558820714 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAF6J77J32L6XWDXPYAVXDQVWG5LANCNFSM4JR5467Q

.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/leaflet-environmental-layers/issues/287?email_source=notifications&email_token=ADSCRRPTQ37HLOPR6QUQFODQVWIQXA5CNFSM4JR54672YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHQADQ#issuecomment-558825486, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSCRRPWNPJDSGSTY42BBATQVWIQXANCNFSM4JR5467Q .