search

publiclab / leaflet-environmental-layers

Collection of different environmental map layers in an easy to use Leaflet library, similar to https://github.com/leaflet-extras/leaflet-providers#leaflet-providers
https://publiclab.github.io/leaflet-environmental-layers/example/
GNU General Public License v3.0
99 stars 77 forks source link

Populate popup data for opensense layer #359

Open crisner opened 4 years ago

crisner commented 4 years ago

The marker for the opensense layer does not have popup content. It needs to be added to the popup from the data for each marker. https://github.com/publiclab/leaflet-environmental-layers/blob/6f6c8a350717458390ca1012d758dd492f0c7125/src/layercode.js#L267-L274

https://github.com/publiclab/leaflet-environmental-layers/blob/6f6c8a350717458390ca1012d758dd492f0c7125/src/layercode.js#L294

127 0 0 1_5500_example_index html (13)

sanjana091001 commented 4 years ago

Can I work on this?

crisner commented 4 years ago

Sure @sanjana091001! Please go ahead.

sanjana091001 commented 4 years ago

I'm new here, can I get some more information about this issue?

crisner commented 4 years ago

If you are new you could take a look at issues that are labelled first-timers-only here: https://code.publiclab.org/#r=all. You may have to dig a little into the code for this one.

sanjana091001 commented 4 years ago

I would really like to work on this issue, can I give it a shot?

crisner commented 4 years ago

Sure! Go ahead and give it a try. 😃 Also, it looks like the popup content is generated here: https://github.com/publiclab/leaflet-environmental-layers/blob/6f6c8a350717458390ca1012d758dd492f0c7125/src/layercode.js#L37-L65

But then the content is not bound to the popup. The content needs to show when we click the markers in this layer. Thanks!

crisner commented 4 years ago

Moved to #391