Unearthing PVD map layers planning issue

[jywarren]

@tmarlow - hi, just touching base about the map layers you're looking to add. cc @emilyashley 👋

My list includes:

• [x] adding a search box (we just merged this!) in https://github.com/publiclab/leaflet-environmental-layers/pull/404 so after testing we'll:
• [x] publish new search box to PublicLab.org
• [ ] adjust icon display: my understanding is you'd like the black markers that indicate "posts" to not overwhelm the smaller blue dots that indicate an industrial site, is that right? More discussion on this below.
• [x] bounding modifications: let's try this through in-page customization, using Leaflet's map.setMaxBounds() (see below)
• [ ] adding laundromat/playground data, ideally by cloning the UnearthingPVD layer (see below)

Icon size discussion

If the above problem statement is right, we could:

1. make the black droplet markers smaller -- like half size
2. make the blue dots bigger (although this makes them harder to read when many are shown)
3. other ideas?

Cloning layers

The original layer we're looking at is here: https://github.com/publiclab/leaflet-environmental-layers/blob/master/src/unearthing.js so we'll copy it as many times as we need.

Change checklist:

• [ ] upload a new JSON data file in same format as the last one, alongside the first, in [this repository]in this repository
• [ ] copy this file -- to a new filename like unearthing-laundromats.js
• change this line to point at the new JSON data file
• [ ] change this line too
• [ ] change variable name here
• [ ] adjust HTML display of properties in the popup on this line
• [ ] adjust color of dot on this line

However, after copying and modifying that file, we also need to change these files and lines to include the new layer:

• [ ] https://github.com/publiclab/leaflet-environmental-layers/blob/bfe20085ecb3374c5476db26dd249a7d4ca55398/src/info.json#L277-L296 (format below)
• [ ] https://github.com/publiclab/leaflet-environmental-layers/blob/master/src/AllLayers.js#L12

For the info.json file above, we need these fields updated for the new layers; if you can add that in a comment here:

    "name": "Unearthing Providence",
    "url": "https://publiclab.org/unearthing-pvd",
    "api_url": "",
    "data": {
      "type": "Historical data",
      "disclaimer": "Social scientists and computer scientists at Brown University have assembled a unique database that contains information on every manufacturing facility that operated in Rhode Island since the early 1950s. The database also contains information on other environmentally risky land uses such as gas stations, dry cleaners, and auto repair shops as far back as 1936. We have also collected information on “green” land uses such as urban parks, playgrounds, schools and community gardens dating back to 1915."
    },
    "description": "A platform for historical data-driven analyses of industrial land use, story-mapping, and community organizing.",
    "layer_desc": "Industrial land use, story-mapping, and community organizing",

Once you do the above steps, please open a pull request with your work! Or, if you'd like, point us (in a comment here) to your branch and we can open it for you. Thanks Tom!!!

We can break this out into different issues as needed. Thanks!

[jywarren]

A quick update: i was able to get the bounding customization working by including this script into the page:

// find map object and limit bounds/zoom
window[Object.keys(window).find(key => key.substr(0,3) === "map")]
  .setMaxBounds([
    [42.2102, -72.0204],
    [41.2272, -70.9618]
  ]).setMinZoom(9)

It's working now at https://publiclab.org/wiki/unearthing-pvd

[jywarren]

Hi @tmarlow - i'd like to make some progress on the marker styling issue. My understanding was that the larger black markers seem to "overwhelm" the smaller blue markers.

I'm cautious about making the blue markers larger because they are so crowded already.

Could one possible solution be to override the marker display for this page and make the black markers smaller? Do you prefer another set of colors? Thanks!

[tmarlow]

Hey Jeff,

Sorry, I don't think I was seeing those earlier messages!

The max bounds solution is perfect.

I think making them larger is not the way to go. Your solution makes more sense to me. I don't really have a preference on the colors. I trust your judgement more than mine on that one.

I've been swamped with other things but I have time the rest of this week to make some progress. I'll keep an eye out and try to be more responsive as well. Sorry, and thanks for your hard work!

-Tom

On Tue, Apr 7, 2020 at 11:59 AM Jeffrey Warren notifications@github.com wrote:

Hi @tmarlow https://github.com/tmarlow - i'd like to make some progress on the marker styling issue. My understanding was that the larger black markers seem to "overwhelm" the smaller blue markers.

I'm cautious about making the blue markers larger because they are so crowded already.

Could one possible solution be to override the marker display for this page and make the black markers smaller? Do you prefer another set of colors? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/leaflet-environmental-layers/issues/448#issuecomment-610472390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65ZLAL3N5TS3OKMMP2HR3RLNEXPANCNFSM4LS2FKPA .

-- Thomas Marlow (he/him) Brown University Department of Sociology, Ph.D. Candidate Trainee, Brown Superfund Research Program Graduate Fellow, Institute at Brown for Environment and Society

[jywarren]

No problem, and a lot of small but important things (like search) are coming together finally and i hope will go live today. Good luck with your work and stay safe!

[jywarren]

Search is now live on https://publiclab.org/map !

And on the unearthing pvd page! https://publiclab.org/wiki/unearthing-pvd