search

publiclab / leaflet-environmental-layers

Collection of different environmental map layers in an easy to use Leaflet library, similar to https://github.com/leaflet-extras/leaflet-providers#leaflet-providers
https://publiclab.github.io/leaflet-environmental-layers/example/
GNU General Public License v3.0
99 stars 77 forks source link

indigenous layers not showing, error #682

Open jywarren opened 2 years ago

jywarren commented 2 years ago

https://publiclab.org/map#9/41.74439221983901/-71.67343139648439

LeafletEnvironmentalLayers.js:13548 listener not found
_off @ LeafletEnvironmentalLayers.js:13548
off @ LeafletEnvironmentalLayers.js:13457
z @ Leaflet.BlurredLocation-e99a2c6a0a272f341e8d11474f1618444fa40b6a62944b10c3ef3832693597ac.js:8
T @ Leaflet.BlurredLocation-e99a2c6a0a272f341e8d11474f1618444fa40b6a62944b10c3ef3832693597ac.js:8
fire @ LeafletEnvironmentalLayers.js:13571
_onDrag @ LeafletEnvironmentalLayers.js:26406
fire @ LeafletEnvironmentalLayers.js:13571
_updatePosition @ LeafletEnvironmentalLayers.js:18915
_onMove @ LeafletEnvironmentalLayers.js:18901
handler @ LeafletEnvironmentalLayers.js:15650
jywarren commented 2 years ago

This error seems to happen a lot; could be related to incompatible plugins?

https://github.com/Leaflet/Leaflet/search?q=%22listener+not+found%22&type=issues

Could be re: setting maxBounds on constructor: https://github.com/Leaflet/Leaflet/issues/8216

Or imageOverlay: https://github.com/Leaflet/Leaflet/issues/8166

Both seem to be fixed in Leaflet's main branch as of April 20, and might have been rolled into 1.8.1 or perhaps 1.9: https://github.com/Leaflet/Leaflet/milestone/38

So although we are seeing this error on PL, I don't think other layers are affected (skytruth, unearthing still work). So we can wait until 1.8.1 or 1.9.0 are released to fix this, although it's not ideal.

jywarren commented 2 years ago

Appreciating 1.9 release coordination going on here! https://github.com/Leaflet/Leaflet/issues/8353

jywarren commented 1 year ago

Leaflet 1.9.2 in https://github.com/publiclab/plots2/pull/11456 !

jywarren commented 1 year ago

On Jenkins build, I found Leaflet was still using 1.8.0 - L.version - rebuilding again... but it should resolve sooner or later.

https://stable.publiclab.org/map