search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 210 forks source link

Liking (stars) for maps #126

Open jywarren opened 9 years ago

jywarren commented 9 years ago

just like on publiclab.org

kaustubh-nair commented 5 years ago

Hey! I'd like to take this issue! I'm thinking of creating a model called map_likes with map_id and user_id as attributes. Would this be sufficient or should I rename it to something else, in case you would incorporate other features like followers? Also should there be any email notification sent after liking?

jywarren commented 5 years ago

Let's name the model map_reactions and have a reaction_type column that has default like, but we could add follow or others in the future. How does that sound? Thanks, and we'd love help -- i do think we are /very/ interested in full unit testing for any new feature so please bear that in mind!

On Thu, Feb 7, 2019 at 12:02 PM Kaustubh Nair notifications@github.com wrote:

Hey! I'd like to take this issue! I'm thinking of creating a model called map_likes with map_id and user_id as attributes. Would this be sufficient or should I rename it to something else in case you would incorporate other features like followers? Also should there be any email notification sent after liking?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/126#issuecomment-461511516, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ2FHaGwWWHhqpDpMbiHYx1X1xkAbks5vLFvqgaJpZM4DlQZW .

kaustubh-nair commented 5 years ago

Sound's good. What other kind of reactions are we having? Github like reactions?

jywarren commented 5 years ago

potentially -- best to just plan ahead!

But wait - what if we thought a bit more about this and made reactions to individual images instead of to maps? We are considering making the platform more image centric in any case. What do you think?

On Thu, Feb 7, 2019 at 2:49 PM Kaustubh Nair notifications@github.com wrote:

Sound's good. What other kind of reactions are we having? Github like reactions?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/126#issuecomment-461570892, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ6pDExuUjWPpbubAkQnSZxarWfHnks5vLIMdgaJpZM4DlQZW .

kaustubh-nair commented 5 years ago

Interesting.. I'm new to Mapknitter here, isn't the point to stitch the images together to create a map? What's more important to the user: the individual images or the stitched map? But if we're going to be more image centric then adding reactions to images makes more sense!

jywarren commented 5 years ago

Yes, i think though that there's a conceptual change we're considering, especially because it may be faster to just start uploading images instead of starting by "creating a map", and then people can just select any group of images to generate an export. Then images can "belong" to multiple collections for export. We're not 100% set on it but it does seem like a simpler mental model with a few less steps. I think either way, it may be useful to "like" or react to individual images rather than whole maps. Is that helpful? Thanks!

On Thu, Feb 7, 2019 at 3:47 PM Kaustubh Nair notifications@github.com wrote:

Interesting.. I'm new to Mapknitter here, isn't the point to stitch the images together to create a map? What's more important to the user: the individual images or the stitched map? But if we're going to be more image centric then adding reactions to images makes more sense!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/126#issuecomment-461589450, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ53qkEC6iC_3ZTgUtcaCbcGYA4ulks5vLJDAgaJpZM4DlQZW .

kaustubh-nair commented 5 years ago

Sounds cool! Thanks for the help. I'll send a pr soon